From 237db9c497b7e9a2825c38e761b937ecf652b146 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Fri, 17 Feb 2017 15:42:21 -0800 Subject: [PATCH] util: cleanup internalUtil.deprecate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There were two functions `deprecate` and `_deprecate` that were really just aliases of each other. Simplify PR-URL: https://github.com/nodejs/node/pull/11450 Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca --- lib/internal/util.js | 10 ++-------- lib/util.js | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/internal/util.js b/lib/internal/util.js index 4f7e9924a94186..b4a938f9c22a89 100644 --- a/lib/internal/util.js +++ b/lib/internal/util.js @@ -10,12 +10,6 @@ const kDecoratedPrivateSymbolIndex = binding['decorated_private_symbol']; // `util` module makes it accessible without having to `require('util')` there. exports.customInspectSymbol = Symbol('util.inspect.custom'); -// All the internal deprecations have to use this function only, as this will -// prepend the prefix to the actual message. -exports.deprecate = function(fn, msg) { - return exports._deprecate(fn, msg); -}; - exports.trace = function(msg) { console.trace(`${prefix}${msg}`); }; @@ -23,11 +17,11 @@ exports.trace = function(msg) { // Mark that a method should not be used. // Returns a modified function which warns once by default. // If --no-deprecation is set, then it is a no-op. -exports._deprecate = function(fn, msg) { +exports.deprecate = function deprecate(fn, msg, code) { // Allow for deprecating things in the process of starting up. if (global.process === undefined) { return function() { - return exports._deprecate(fn, msg).apply(this, arguments); + return exports.deprecate(fn, msg, code).apply(this, arguments); }; } diff --git a/lib/util.js b/lib/util.js index 8f4ada10ce5bad..64c4c94c29a81f 100644 --- a/lib/util.js +++ b/lib/util.js @@ -131,7 +131,7 @@ exports.format = function(f) { }; -exports.deprecate = internalUtil._deprecate; +exports.deprecate = internalUtil.deprecate; var debugs = {};