Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1494: add optionals to all input fields process #1698

Merged
merged 2 commits into from
May 22, 2024

Conversation

lehju
Copy link
Contributor

@lehju lehju commented May 21, 2024

Description

add optionals to all input fields process

Reference

Issues: #1494

Check-List

  • No waste on Branch left (e.g. console.logs)

@github-actions github-actions bot added digiwf-engine bug Something isn't working labels May 21, 2024
@lehju lehju self-assigned this May 21, 2024
@lehju lehju requested a review from markostreich May 21, 2024 11:49
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.73%. Comparing base (0605189) to head (b7d4779).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1698   +/-   ##
=========================================
  Coverage     44.73%   44.73%           
  Complexity     1706     1706           
=========================================
  Files           653      653           
  Lines          9629     9629           
  Branches        477      477           
=========================================
  Hits           4308     4308           
  Misses         5139     5139           
  Partials        182      182           
Flag Coverage Δ
unittests 44.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir requested review from simonhir and removed request for markostreich May 22, 2024 07:12
Copy link
Member

@simonhir simonhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehju lehju merged commit fccc8ee into dev May 22, 2024
14 checks passed
@lehju lehju deleted the bugfix/#1494-add-optionals-to-all-input-fields branch May 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants