{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":203845904,"defaultBranch":"master","name":"admiral","ownerLogin":"istio-ecosystem","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-08-22T17:53:04.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/43223487?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726276578.0","currentOid":""},"activityList":{"items":[{"before":"5fb54154489f19b43c2dd14aeec3aade0b3b07e3","after":"c0444fb860b9eb6cd93487a21795bf14200c7729","ref":"refs/heads/master","pushedAt":"2024-09-19T04:51:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"shriramsharma","name":"Shriram Sharma","path":"/shriramsharma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/611926?s=80&v=4"},"commit":{"message":"added a cluster allowlist param for vs based routing (#346)","shortMessageHtmlLink":"added a cluster allowlist param for vs based routing (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531542605\" data-permission-text=\"Title is private\" data-url=\"https://github.com/istio-ecosystem/admiral/issues/346\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/istio-ecosystem/admiral/pull/346/hovercard\" href=\"https://github.com/istio-ecosystem/admiral/pull/346\">#346</a>)"}},{"before":"f4d767cccdf285bebd304cfcb7bb27272f02bf41","after":"5fb54154489f19b43c2dd14aeec3aade0b3b07e3","ref":"refs/heads/master","pushedAt":"2024-09-18T22:15:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"shriramsharma","name":"Shriram Sharma","path":"/shriramsharma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/611926?s=80&v=4"},"commit":{"message":"added the gtp implementation (#344)","shortMessageHtmlLink":"added the gtp implementation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2529629971\" data-permission-text=\"Title is private\" data-url=\"https://github.com/istio-ecosystem/admiral/issues/344\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/istio-ecosystem/admiral/pull/344/hovercard\" href=\"https://github.com/istio-ecosystem/admiral/pull/344\">#344</a>)"}},{"before":"3f7eb67e99177bab8ba4877ffbc6470a15d91f43","after":"f4d767cccdf285bebd304cfcb7bb27272f02bf41","ref":"refs/heads/master","pushedAt":"2024-09-18T16:28:44.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"shriramsharma","name":"Shriram Sharma","path":"/shriramsharma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/611926?s=80&v=4"},"commit":{"message":"Merge pull request #345 from shriramsharma/add-warmupduration-ingress-dr\n\nadded warmupDurationSeconds to ingress DR","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531532013\" data-permission-text=\"Title is private\" data-url=\"https://github.com/istio-ecosystem/admiral/issues/345\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/istio-ecosystem/admiral/pull/345/hovercard\" href=\"https://github.com/istio-ecosystem/admiral/pull/345\">#345</a> from shriramsharma/add-warmupduration-ingress-dr"}},{"before":"61e7c3f8a89725576cfc37b2ce5f85066d855ca4","after":"3f7eb67e99177bab8ba4877ffbc6470a15d91f43","ref":"refs/heads/master","pushedAt":"2024-09-16T23:09:17.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"shriramsharma","name":"Shriram Sharma","path":"/shriramsharma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/611926?s=80&v=4"},"commit":{"message":"Merge pull request #338 from shriramsharma/generate-ingress-dr\n\ngenerating ingress DR for VS based routing","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2514327134\" data-permission-text=\"Title is private\" data-url=\"https://github.com/istio-ecosystem/admiral/issues/338\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/istio-ecosystem/admiral/pull/338/hovercard\" href=\"https://github.com/istio-ecosystem/admiral/pull/338\">#338</a> from shriramsharma/generate-ingress-dr"}},{"before":"eb9ceec7946ae048607f16f39e73caf002be55ed","after":null,"ref":"refs/heads/MESH-5515-DeploymentToRolloutFix","pushedAt":"2024-09-14T01:16:18.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"}},{"before":"eb024bea5e36935c4bc321e09ab0e868024910ea","after":"61e7c3f8a89725576cfc37b2ce5f85066d855ca4","ref":"refs/heads/master","pushedAt":"2024-09-14T01:16:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5515] Add 'security.istio.io/tlsMode' label to SE endpoints for deployment to rollout migration usecase (#343)\n\n- Updated various test cases to include the 'security.istio.io/tlsMode'\r\nlabel in Service Entries and Workload Entries.\r\n- Modified validation logic to check for the presence of the\r\n'security.istio.io/tlsMode' label.\r\n- Refactored code to ensure the 'security.istio.io/tlsMode' label is\r\nadded where necessary.\r\n- Enhanced error handling in validation functions to provide detailed\r\nerror messages.\r\n\r\n### Checklist\r\n🚨 Please review this repository's [contribution\r\nguidelines](./CONTRIBUTING.md).\r\n\r\n- [ ] I've read and agree to the project's contribution guidelines.\r\n- [ ] I'm requesting to **pull a topic/feature/bugfix branch**.\r\n- [ ] I checked that my code additions will pass code linting checks and\r\nunit tests.\r\n- [ ] I updated unit and integration tests (if applicable).\r\n- [ ] I'm ready to notify the team of this contribution.\r\n\r\n### Description\r\nWhat does this change do and why?\r\n\r\n[Link to related ISSUE]\r\n\r\nThank you!\r\n\r\n---------\r\n\r\nCo-authored-by: Punakshi <punakshi_chaand@intuit.com>","shortMessageHtmlLink":"[MESH-5515] Add 'security.istio.io/tlsMode' label to SE endpoints for…"}},{"before":"b8470b7b81dcd82ff0acdb251c7980e31aeba801","after":null,"ref":"refs/heads/MESH-5465-Validate-filter","pushedAt":"2024-09-13T19:54:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"}},{"before":"4b3327930606048376d681015c4d0852e190f912","after":"eb024bea5e36935c4bc321e09ab0e868024910ea","ref":"refs/heads/master","pushedAt":"2024-09-13T19:54:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5465] Add validation and utility functions for identities with partitions (#342)\n\n- Added `IsAGateway` and\r\n`GetPartitionAndOriginalIdentifierFromPartitionedIdentifier` functions\r\nin `common.go` to validate and parse gateway asset aliases.\r\n- Introduced `GetWorkloadSelectorLabels` function in `envoyfilter.go` to\r\ngenerate workload selector labels based on asset aliases.\r\n- Updated `constructEnvoyFilterStruct` to use\r\n`GetWorkloadSelectorLabels`.\r\n- Added unit tests for the new functions in `common_test.go` and\r\n`envoyfilter_test.go`.\r\n- Included `GatewayAssetAliases` in test configurations.\r\n\r\n### Checklist\r\n🚨 Please review this repository's [contribution\r\nguidelines](./CONTRIBUTING.md).\r\n\r\n- [x] I've read and agree to the project's contribution guidelines.\r\n- [x] I'm requesting to **pull a topic/feature/bugfix branch**.\r\n- [x] I checked that my code additions will pass code linting checks and\r\nunit tests.\r\n- [x] I updated unit and integration tests (if applicable).\r\n- [x] I'm ready to notify the team of this contribution.\r\n\r\n### Description\r\nWhat does this change do and why?\r\n\r\n[Link to related ISSUE]\r\n\r\nThank you!\r\n\r\n---------\r\n\r\nCo-authored-by: Punakshi <punakshi_chaand@intuit.com>","shortMessageHtmlLink":"[MESH-5465] Add validation and utility functions for identities with …"}},{"before":"fc13fc493bd141d31175ca33140b1eb96780c5ab","after":"eb9ceec7946ae048607f16f39e73caf002be55ed","ref":"refs/heads/MESH-5515-DeploymentToRolloutFix","pushedAt":"2024-09-13T19:44:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"```\n[MESH-5515] Rename validateServiceEntry to validateServiceEntryEndpoints","shortMessageHtmlLink":"```"}},{"before":"82d0384f17b36ce0f86116efc94febec521840cc","after":"b8470b7b81dcd82ff0acdb251c7980e31aeba801","ref":"refs/heads/MESH-5465-Validate-filter","pushedAt":"2024-09-13T04:38:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5465] Update sample gateway asset aliases","shortMessageHtmlLink":"[MESH-5465] Update sample gateway asset aliases"}},{"before":"052779b172cccae196c9aec3ad78f062f2200455","after":"82d0384f17b36ce0f86116efc94febec521840cc","ref":"refs/heads/MESH-5465-Validate-filter","pushedAt":"2024-09-13T04:38:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5465] Update sample gateway asset aliases","shortMessageHtmlLink":"[MESH-5465] Update sample gateway asset aliases"}},{"before":"feb7bb04ba805bf9a003cb0171005bb6a1c2d1ee","after":"052779b172cccae196c9aec3ad78f062f2200455","ref":"refs/heads/MESH-5465-Validate-filter","pushedAt":"2024-09-13T04:16:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5465] Update sample gateway asset aliases","shortMessageHtmlLink":"[MESH-5465] Update sample gateway asset aliases"}},{"before":null,"after":"fc13fc493bd141d31175ca33140b1eb96780c5ab","ref":"refs/heads/MESH-5515-DeploymentToRolloutFix","pushedAt":"2024-09-13T04:01:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"```\n[MESH-5515] Add 'security.istio.io/tlsMode' label to Service Entries and Workload Entries during deployment to rollout migration usecase\n\n- Updated various test cases to include the 'security.istio.io/tlsMode' label in Service Entries and Workload Entries.\n- Modified validation logic to check for the presence of the 'security.istio.io/tlsMode' label.\n- Refactored code to ensure the 'security.istio.io/tlsMode' label is added where necessary.\n- Enhanced error handling in validation functions to provide detailed error messages.","shortMessageHtmlLink":"```"}},{"before":"f8952d620cd64309d8f88c95041985039350a148","after":"440dac87718bafe52e92123d2faaa1ffc9e0aa4c","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-12T22:40:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Fix types","shortMessageHtmlLink":"Fix types"}},{"before":"e8546c9d3031647c4ee4eae89ba943c453d6fbce","after":"f8952d620cd64309d8f88c95041985039350a148","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-12T22:25:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Enable client discovery based on the flags","shortMessageHtmlLink":"Enable client discovery based on the flags"}},{"before":"5e50dbd412f74bb80f55227a119a2ab94d18b08b","after":null,"ref":"refs/heads/MESH-5509-Ensure-Locality-Label","pushedAt":"2024-09-12T18:26:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"}},{"before":"a383b2c29285a3d0c8dafa4d8a03c8bd08db66d2","after":"4b3327930606048376d681015c4d0852e190f912","ref":"refs/heads/master","pushedAt":"2024-09-12T18:26:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5509] Ensure Locality Label in Service Entries (#341)\n\n- Added `Locality` field to `WorkloadEntry` in `serviceentry_test.go`.\r\n- Implemented `validateLocalityInServiceEntry` function to check\r\nlocality in service entries.\r\n- Integrated locality validation in service entry reconciliation logic.\r\n- Modified `NewNodeController` to accept `resyncPeriod` parameter.\r\n- Updated tests to reflect changes in `NewNodeController` signature.\r\n\r\n### Checklist\r\n🚨 Please review this repository's [contribution\r\nguidelines](./CONTRIBUTING.md).\r\n\r\n- [x] I've read and agree to the project's contribution guidelines.\r\n- [x] I'm requesting to **pull a topic/feature/bugfix branch**.\r\n- [x] I checked that my code additions will pass code linting checks and\r\nunit tests.\r\n- [x] I updated unit and integration tests (if applicable).\r\n- [x] I'm ready to notify the team of this contribution.\r\n\r\n### Description\r\nWhat does this change do and why?\r\n\r\n[Link to related ISSUE]\r\n\r\nThank you!\r\n\r\n---------\r\n\r\nCo-authored-by: Punakshi <punakshi_chaand@intuit.com>","shortMessageHtmlLink":"[MESH-5509] Ensure Locality Label in Service Entries (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2521011278\" data-permission-text=\"Title is private\" data-url=\"https://github.com/istio-ecosystem/admiral/issues/341\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/istio-ecosystem/admiral/pull/341/hovercard\" href=\"https://github.com/istio-ecosystem/admiral/pull/341\">#341</a>)"}},{"before":"fffa5d30ecbb50147b44d176eedbe07a81d72003","after":"e8546c9d3031647c4ee4eae89ba943c453d6fbce","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-12T18:24:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Numaflow install and flags for Client Discovery","shortMessageHtmlLink":"Numaflow install and flags for Client Discovery"}},{"before":"232eeb124d4ae42319fe1532df2f826bd7c396d6","after":"fffa5d30ecbb50147b44d176eedbe07a81d72003","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-12T18:00:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Code review feedback","shortMessageHtmlLink":"Code review feedback"}},{"before":"dcc21da6577afd2e7e79b4162f24fe14e670a41c","after":"5e50dbd412f74bb80f55227a119a2ab94d18b08b","ref":"refs/heads/MESH-5509-Ensure-Locality-Label","pushedAt":"2024-09-12T16:53:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5509] Update node locality label test to expect no error for empty region","shortMessageHtmlLink":"[MESH-5509] Update node locality label test to expect no error for em…"}},{"before":"647bfa03d2d018b5d4741c2fbe6ace326f15d19c","after":"dcc21da6577afd2e7e79b4162f24fe14e670a41c","ref":"refs/heads/MESH-5509-Ensure-Locality-Label","pushedAt":"2024-09-12T16:41:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"Improve logging for empty region in NodeController","shortMessageHtmlLink":"Improve logging for empty region in NodeController"}},{"before":"89cfc4d3c84b35939024e3e6dc1f7881523e9340","after":"647bfa03d2d018b5d4741c2fbe6ace326f15d19c","ref":"refs/heads/MESH-5509-Ensure-Locality-Label","pushedAt":"2024-09-12T16:39:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5509] Add tests for Node locality label handling in NodeController","shortMessageHtmlLink":"[MESH-5509] Add tests for Node locality label handling in NodeController"}},{"before":"d47c4c052c5f1845cf7c37b03611e4ade8131744","after":"89cfc4d3c84b35939024e3e6dc1f7881523e9340","ref":"refs/heads/MESH-5509-Ensure-Locality-Label","pushedAt":"2024-09-12T16:29:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"Improve error handling for empty region in NodeController","shortMessageHtmlLink":"Improve error handling for empty region in NodeController"}},{"before":"61b23e870269e16150369120ae694c33c4b47f43","after":"232eeb124d4ae42319fe1532df2f826bd7c396d6","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-12T07:22:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Return error when failed to type cast.","shortMessageHtmlLink":"Return error when failed to type cast."}},{"before":null,"after":"feb7bb04ba805bf9a003cb0171005bb6a1c2d1ee","ref":"refs/heads/MESH-5465-Validate-filter","pushedAt":"2024-09-12T03:05:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5465] Add validation and utility functions for gateway asset aliases\n\n- Added `IsAGateway` and `GetPartitionAndOriginalIdentifierFromPartitionedIdentifier` functions in `common.go` to validate and parse gateway asset aliases.\n- Introduced `GetWorkloadSelectorLabels` function in `envoyfilter.go` to generate workload selector labels based on asset aliases.\n- Updated `constructEnvoyFilterStruct` to use `GetWorkloadSelectorLabels`.\n- Added unit tests for the new functions in `common_test.go` and `envoyfilter_test.go`.\n- Included `GatewayAssetAliases` in test configurations.","shortMessageHtmlLink":"[MESH-5465] Add validation and utility functions for gateway asset al…"}},{"before":"3424cab18bfc41fc42c1f27227301654d27cf30e","after":"d47c4c052c5f1845cf7c37b03611e4ade8131744","ref":"refs/heads/MESH-5509-Ensure-Locality-Label","pushedAt":"2024-09-11T23:53:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5509] Ensure Locality Label in Service Entries\n\n- Added `Locality` field to `WorkloadEntry` in `serviceentry_test.go`.\n- Implemented `validateLocalityInServiceEntry` function to check locality in service entries.\n- Integrated locality validation in service entry reconciliation logic.\n- Modified `NewNodeController` to accept `resyncPeriod` parameter.\n- Updated tests to reflect changes in `NewNodeController` signature.","shortMessageHtmlLink":"[MESH-5509] Ensure Locality Label in Service Entries"}},{"before":null,"after":"3424cab18bfc41fc42c1f27227301654d27cf30e","ref":"refs/heads/MESH-5509-Ensure-Locality-Label","pushedAt":"2024-09-11T23:43:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Punakshi","name":"Punakshi Chaand","path":"/Punakshi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16400217?s=80&v=4"},"commit":{"message":"[MESH-5509] Ensure Locality Label in Service Entries\n\n- Added `Locality` field to `WorkloadEntry` in `serviceentry_test.go`.\n- Implemented `validateLocalityInServiceEntry` function to check locality in service entries.\n- Integrated locality validation in service entry reconciliation logic.\n- Modified `NewNodeController` to accept `resyncPeriod` parameter.\n- Updated tests to reflect changes in `NewNodeController` signature.","shortMessageHtmlLink":"[MESH-5509] Ensure Locality Label in Service Entries"}},{"before":"c340edf3eb04e7c3eb42ad2aa2e853ee9e1d0526","after":"61b23e870269e16150369120ae694c33c4b47f43","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-11T22:37:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Move K8sObject to common/types.go","shortMessageHtmlLink":"Move K8sObject to common/types.go"}},{"before":"585c2ea5d9dab5642352f2c8f14794cb1b8006bb","after":"c340edf3eb04e7c3eb42ad2aa2e853ee9e1d0526","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-11T20:24:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Build fix","shortMessageHtmlLink":"Build fix"}},{"before":"9c1af472fc360a637803e02aa4302cedd6161aa2","after":"585c2ea5d9dab5642352f2c8f14794cb1b8006bb","ref":"refs/heads/Seperate-out-service-and-client-discovery","pushedAt":"2024-09-11T06:21:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aattuluri","name":"aattuluri","path":"/aattuluri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/44482891?s=80&v=4"},"commit":{"message":"Round 2","shortMessageHtmlLink":"Round 2"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEumpj_AA","startCursor":null,"endCursor":null}},"title":"Activity · istio-ecosystem/admiral"}