Fix OCaml language support #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various improvements: - character support - type variable - polymorphic variant tag - module name/variant constructor - support ' in identifier - add support for literals () [] [||] - better support for numbers - remove unrelated rules (from F# maybe?) - add new ! keywords - cleanup built-in types A step backward: remove very incomplete type definition matching Add tests B)
|
This is a very comprehensive work, thank you! Merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major concern with the state of OCaml in Highlight.js is about the apostrophe
'. They are very used in OCaml : they are allowed in identifiers (my_var'), and are used to prefix "generic" types (type variable, e.g. in'a listtype of a generic list). Yet the existing language description, totally ignore it (except for character literals) and as a result the first use of'messes up the highlighting of the rest of the code (in particular interfaces).The proposed modification provides various improvements:
'a)[A |B ])Listor constructorSome a)'in identifier()[][||]method!,open!etc.)A step backward: remove very incomplete type definition. It would not have been easy to really support that and in terms of highlighting I don't think it's worth it.
The complete test suite sucessfully run including the language detection.
Cheers, M