Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding large blocks/directories (4MiB+) should cause error #5282

Open
NiKiZe opened this issue Jul 25, 2018 · 0 comments
Open

Adding large blocks/directories (4MiB+) should cause error #5282

NiKiZe opened this issue Jul 25, 2018 · 0 comments
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog

Comments

@NiKiZe
Copy link

NiKiZe commented Jul 25, 2018

As mentioned in ipfs/notes#296 (comment)

I guess there is some hard limit on "do not accepts blocks over this size"

The generated directories are large and don't work, example:
QmY6jEuqY3U5N9yxeBs6uoM63QnV2gjewXop9U4cQKauX8 has a distfiles directory with hash QmWvMmUjrH6neokv6RTqdgaYZSgxzr6hrjqaHosnDh6o7C which is 4821289 bytes in one block, I have republished that raw block as QmNzePsWN7kCF9fvbFBAnoVERWbCiVFjVEmr5EFqXFLtxL, Another example is QmfSAWwPTx5Kmre4bDF3zbkDuYXeNo9X7eTLvRUxyfr52B which can be found in QmPctnSoGCY8j19Lhxez3wqH2Ld55DzSqjnrbvNUuxoYgw. Using Sharding as described in #212 might solve this, but still the client should give error (or at least warning) when this happens.
I guess that is the size here that is the issue? But should go-ipfs allow to create so large blocks? (It would be better for it to throw an error until there is a fix) I get a feeling there already must be an issue created about this?, but can't find a good match (that is still open)

What I recommend is that the client errors out if a block larger then that max limit is added.
For those cases where this needs to be supported an extra flag can be added --allow-oversized-blocks

If an error can't be added then a Warning could be enough.

This message could also point to an issue disscussing this, or directions recommendingt to enable sharding.

@Stebalien Stebalien added kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked help wanted Seeking public contribution on this issue labels Jul 25, 2018
@Stebalien Stebalien added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

No branches or pull requests

2 participants