Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dht query early exit bug #308

Closed
whyrusleeping opened this issue Nov 12, 2014 · 5 comments
Closed

dht query early exit bug #308

whyrusleeping opened this issue Nov 12, 2014 · 5 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@whyrusleeping
Copy link
Member

I noticed a slight bug that probably hasnt caused any issues yet, but nonetheless, i beleive its a bug.
While running dhthell tests, i had one node do a 'put key val' and was presented the following messages:

21:43:08.365 ERROR    service: no request key [18 32 56 87 188 82 106 161 234 18 6 15 48 115 70 138 1 94 1 232 248 64 73 130 16 191 144 247 243 98 57 202 60 29 50 35 161 43] (timeout?) service.go:240
21:43:08.365 ERROR    service: no request key [18 32 84 248 159 180 219 214 155 152 31 80 88 56 55 235 130 185 4 148 136 244 0 39 99 23 238 207 187 125 101 171 241 133 53 93 58 177] (timeout?) service.go:240

Which up until now, i had been ignoring, but when i went to investigate what caused them, i found that as soon as a single 'PUT' query finished, we cancelled the context for all of them, causing their response handlers to be removed. Which, if we had any put queries that hadnt been run yet, would have caused our value to not have been propogated correctly (fortunately, our PUT operations all get sent out at the same time).

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Nov 12, 2014
@jbenet
Copy link
Member

jbenet commented Nov 17, 2014

Oh, not so good. so this is a problem of specifying to the query runner when a query is done, correct?

@whyrusleeping
Copy link
Member Author

yeah, basically it assumes that its done as soon as it receives a single 'successful' response.

@jbenet
Copy link
Member

jbenet commented Dec 9, 2014

#423

@jbenet
Copy link
Member

jbenet commented Jan 15, 2015

@whyrusleeping is this still a problem?

@whyrusleeping
Copy link
Member Author

This has been addressed and we should be able to close this one out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants