Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Updating Docs in accordance with error #4130 #4170

Closed
wants to merge 1 commit into from

Conversation

HackStrix
Copy link

@HackStrix HackStrix commented Jul 27, 2022

Updating IPFS-HTTP-CLIENT docs in accordance with the issue highlighted in #4130, ERR_PACKAGE_PATH_NOT_EXPORTED with ipfs-http-client and typescript.

closes #4169

In accordance with ERR_PACKAGE_PATH_NOT_EXPORTED with ipfs-http-client and typescript. Suggested fixes do not work. ipfs#4130
@welcome
Copy link

welcome bot commented Jul 27, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@achingbrain
Copy link
Member

Thanks for opening this.

You can use import in ESM code, no need to use import(), that's only needed in older CJS code. The examples are ESM since the IPFS modules are ESM.

If you are seeing ERR_PACKAGE_PATH_NOT_EXPORTED with ipfs-http-client and typescript, please check your output settings, you're probably outputting CJS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfs-http-client import issue, can't import module
2 participants