This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor: object APIs write methods now return CIDs #1730
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c0bb784
fix: better input validation for add
alanshaw f23eda9
chore: update interface-ipfs-core dependency
alanshaw bdc6f4d
refactor: object APIs write methods now return CIDs
alanshaw d6bc706
refactor: object API in CLI
alanshaw 4a8cba2
chore: use latest ipfs-http-client
alanshaw 9fffa2f
chore: update ipfsd-ctl dependency
alanshaw 2702aea
chore: update ipfsd-ctl dependency
alanshaw 680ebc7
Merge branch 'fix/files-add' into refactor/object-api
alanshaw 0fc03c3
fix: tests
alanshaw a1bac03
fix: more test fix
alanshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
offline mode - uses IPFS core directly | ||
┌───────────────────────────────────────────┐ | ||
│ │ | ||
│ │ | ||
│ online mode - uses IPFS through http-api │ | ||
┌────────────┐ │ ┌────────────────────┐ │ ┌──────────┐ | ||
│ │ │ ┌ ─ ─ ─ ─ ─ ─ │ │ │ │ │ | ||
│ CLI │───┴── ipfs-api ├──▶│ HTTP-API │───┴───▶│IPFS Core │ | ||
│ │ └ ─ ─ ─ ─ ─ ─ │ │ │ │ | ||
└────────────┘ └────────────────────┘ └──────────┘ | ||
△ △ △ | ||
├───────────────────────────────────────┴────────────────────────┘ | ||
│ | ||
┌────────────┐ | ||
│ Tests │ | ||
└────────────┘ | ||
|
||
offline mode - uses IPFS core directly | ||
┌────────────────────────────────────────────┐ | ||
│ │ | ||
│ │ | ||
│ online mode - uses IPFS through http-api │ | ||
┌────────────┐ │ ┌─────────────┐ │ ┌─────────┐ | ||
│ │ │ ┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ │ │ │ │ │ | ||
│ CLI │───┴── ipfs-http-client ├──▶│ HTTP-API │───┴───▶│IPFS Core│ | ||
│ │ └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ │ │ │ │ | ||
└────────────┘ └─────────────┘ └─────────┘ | ||
△ △ △ | ||
├───────────────────────────────────────────┴────────────────────┘ | ||
│ | ||
┌────────────┐ | ||
│ Tests │ | ||
└────────────┘ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes so much more sense now! :D