Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Files Quest #156

Closed
wants to merge 25 commits into from
Closed

Files Quest #156

wants to merge 25 commits into from

Conversation

nginnever
Copy link
Member

@nginnever nginnever commented Apr 22, 2016

TODO

- [x] add CLI (tuples suplied to new awesomeness importer) - [ ] progress bar - [x] fix path names - [x] add HTTP-API - [x] cat CLI - [x] throw daemon not supported err - [x] cat HTTP-API - [x] get CLI - [ ] add progress bar - [x] get HTTP-API - [ ] get JS-IPFS-API - [x] Fix add to respond to no path supplied - [x] fix INIT to place config with new importer - [x] Tests - [x] files add core - [x] files add cli - [x] files add http-api - [x] files cat core - [x] files cat cli - [x] files cat http-api - [x] files get core - [x] files get cli - [x] files get http-api

Blockers

- [x] unixfs-engine readable stream error issue

Call to Action

@bgrieder if you are still interested in the files commands that you were working we would love some help on this PR. Finally organized everything into a place that we can collab. This should close pull 104

@xicombd as I get into writing the http things I could use some help if possible. I hear you are pro at these things :D

Let the quest begin!

@jbenet jbenet added the status/in-progress In progress label Apr 22, 2016
@daviddias daviddias mentioned this pull request Apr 22, 2016
14 tasks
if (err) {
throw new Error(err)
}
res.on('data', (data) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just res.pipe(process.stdout)

daviddias referenced this pull request in ipfs/js-ipfs-repo May 2, 2016
try {
fs.mkdirSync(dir + filepath)
} catch (err) {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can this err be ignored?

@daviddias
Copy link
Member

daviddias commented May 5, 2016

@Voxelot can you break this PR into two that

  • 1st - Implement Files at the IPFS Core Level and CLI Offline
  • 2nd - Implement Files with js-ipfs daemon on, ensuring its compatibility with go-ipfs, this means:
    • go-ipfs cli -> js-ipfs http api
    • js-ipfs cli -> go-ipfs http api

I'm requesting this because it seems that you are close, or even 100% done for the 1st and still a bit far from having the 2nd 100%. Currently, not having the 1st complete is blocking the pursuit of js-ipfs running on the browser with the Files API.

This will also give you a chance to get a clean commit history for these PR's

@nginnever
Copy link
Member Author

Closing this in favor of new HTTP branch and completion of CLI PR 204

@nginnever nginnever closed this May 10, 2016
@jbenet jbenet removed the status/in-progress In progress label May 10, 2016
@nginnever nginnever deleted the files branch May 10, 2016 04:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants