Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: use package-table vs custom script #1525

Merged
merged 1 commit into from
Aug 22, 2018
Merged

feat: use package-table vs custom script #1525

merged 1 commit into from
Aug 22, 2018

Conversation

daviddias
Copy link
Member

No description provided.

@ghost ghost assigned daviddias Aug 22, 2018
@ghost ghost added the status/in-progress In progress label Aug 22, 2018
@daviddias daviddias mentioned this pull request Aug 22, 2018
Closed
alanshaw
alanshaw approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviddias
Copy link
Member Author

CI is failing for unrelated changes to this PR. @alanshaw was there a PR merged that wasn't green?

@daviddias daviddias merged commit 4561f65 into master Aug 22, 2018
@daviddias daviddias deleted the package-table branch August 22, 2018 16:14
@ghost ghost removed the status/in-progress In progress label Aug 22, 2018
@alanshaw
Copy link
Member

was there a PR merged that wasn't green?

Not on my watch!

#1518 (TLDR; ipfs add --cid-version=1 causes js-ipfs to give back a CID that addresses an empty DAG node) was fixed in ipfs-unixfs-engine, released, and caused some tests to break here.

Turns out the tests were expecting the wrong CID so I created this PR to fix them #1523

In doing so it highlighted a different problem with interop - a small file created with --cid-version=1 --raw-leaves=true is getting a different CID in js-ipfs to go-ipfs.

I am in the process of creating a new PR to interop to ensure it doesn't happen again, and also another PR to ipfs-unixfs-engine to address the issue.

I appreciate this is an undesirable state to have master in and I'm working as fast as I can to restore it to green.

@daviddias
Copy link
Member Author

Understood and thank you for being on top of it, @alanshaw! ❤️

@baby636 baby636 mentioned this pull request Jul 31, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Aug 1, 2022
Open
@thexdesk thexdesk mentioned this pull request Aug 1, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees

@daviddias daviddias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @alanshaw