Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[cli] ipfs files add is broken in online mode #480

Closed
dignifiedquire opened this issue Sep 12, 2016 · 1 comment
Closed

[cli] ipfs files add is broken in online mode #480

dignifiedquire opened this issue Sep 12, 2016 · 1 comment
Assignees
@dignifiedquire
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@dignifiedquire
Copy link
Member

I don't know why the tests didn't caught this, but running ipfs files add <file> throws. The reason is that it uses .createAddPullStream which does not exist on the js-ipfs-api only on js-ipfs.

This is one of the reasons pull-streams need to be added in a sensible way to interface-ipfs-core. For now we will have to fall back to the super inefficient thing of converting to a node-stream, and then back to a pull-stream :/

cc @diasdavid
@dignifiedquire dignifiedquire added kind/bug A bug in existing code (including security flaws) exploration milestone 2 labels Sep 12, 2016
@dignifiedquire dignifiedquire changed the title ipfs files add is broken in online mode [cli] ipfs files add is broken in online mode Sep 12, 2016
@daviddias
Copy link
Member

daviddias commented Sep 12, 2016 •
edited
Loading

pull-streams need to be added in a sensible way to interface-ipfs-core

Exactly. It seems more like a misunderstanding of interface-ipfs-core, since that is what the CLI should be consuming.

@dignifiedquire dignifiedquire mentioned this issue Sep 12, 2016
Merged
@dignifiedquire dignifiedquire self-assigned this Sep 12, 2016
dignifiedquire added a commit that referenced this issue Sep 13, 2016
@dignifiedquire
fix(cli): make ipfs files add work online and offline
9e3db34 
Fixes #480
daviddias pushed a commit that referenced this issue Sep 13, 2016
@dignifiedquire @daviddias
fix(cli): make ipfs files add work online and offline
8cd47c6 
Fixes #480
daviddias pushed a commit that referenced this issue Sep 13, 2016
@dignifiedquire @daviddias
fix(cli): make ipfs files add work online and offline
5f22be4 
Fixes #480
daviddias pushed a commit that referenced this issue Sep 13, 2016
@dignifiedquire @daviddias
fix(cli): make ipfs files add work online and offline
86b69bd 
Fixes #480
daviddias pushed a commit that referenced this issue Sep 13, 2016
@dignifiedquire @daviddias
fix(cli): make ipfs files add work online and offline
3edc2b9 
Fixes #480
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this issue May 22, 2020
@alanshaw
chore(package): update aegir to version 19.0.3 (ipfs#485)
74bccc2 
* chore(package): update aegir to version 19.0.3

Closes ipfs#480

* fix: appease linter

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dignifiedquire dignifiedquire

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @daviddias