This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
0.3.10 #169
Merged
0.3.10 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diasdavid looks like webpack logging needs be silenced |
dignifiedquire
force-pushed
the
0.3.10
branch
from
16a0ae2
to
15bb5e1
Compare
|
|
@diasdavid as far as I'm concerned this is ready to merge |
|
awesome 👍 will look into this tomorrow properly to merge and publish :) |
daviddias
added a commit
to daviddias/vinyl-fs
that referenced
this pull request
Dec 19, 2015
We have hit a issue on ipfs-inactive/js-ipfs-http-client#169 because glob-stream 5.3.0 has a new version of micromatch which breaks js-ipfs-api. (please someone call the semver police 🚨 :P) @dignifiedquire has locked 5.2.0 on js-ipfs-api, but to avoid having to cause more people pass through the debugging of this problem if they decide to use this module, I'm just going to make it more strict here too.
|
Thank you @dignifiedquire @fazo96 I've also submitted a small PR to jbenet/vinyl-fs#3 so that in the future other people that use it don't hit the same problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started this, found a bug, but seems to be on the gulp karma task and not js-ipfs-api itself, tests print a ton more stuff then they used too.
Running the tests on master yield the same error, @dignifiedquire any ideas? My first thought is that there was some patch upgrade in some of the babel+gulp+karma dependencies that broke things, which makes sense why all greenkeeper PRs now warn of breaking build
moved to gist