Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to go-libp2p-kad-dht@v0.16.0 #9005

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Conversation

guseggert
Copy link
Contributor

No description provided.

@guseggert guseggert force-pushed the feat/kad-v0.16 branch 4 times, most recently from 1177889 to 87eea1a Compare June 3, 2022 02:04
@guseggert guseggert marked this pull request as ready for review June 3, 2022 02:24
CHANGELOG.md Outdated Show resolved Hide resolved
core/commands/cid.go Show resolved Hide resolved
test/sharness/t0290-cid.sh Outdated Show resolved Hide resolved
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, but we need to rename cid format --codec to cid format --mc to avoid silent bugs (details inline)

CHANGELOG.md Outdated Show resolved Hide resolved
@guseggert
Copy link
Contributor Author

guseggert commented Jun 3, 2022

Also error cases here are not possible to test with sharness, because CID commands ignore all errors. E.g. a commad like ipfs cid format --codec foo -v 39 QmThisIsNoCID outputs nothing with exit code 0. The best I can do is test that nothing is output. Or break these commands further and start outputting errors.

UPDATE: exit code is now tracked in #9007

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (fixed sharness)

@guseggert guseggert merged commit 8d7ed00 into master Jun 3, 2022
@guseggert guseggert deleted the feat/kad-v0.16 branch June 3, 2022 20:56
guseggert added a commit that referenced this pull request Jun 8, 2022
* feat: upgrade to go-libp2p-kad-dht@v0.16.0

* rename "cid format --codec" to "cid format --mc"

* refactor(test): from --codec to --mc

Co-authored-by: Marcin Rataj <lidel@lidel.org>
guseggert added a commit that referenced this pull request Jun 8, 2022
* feat: upgrade to go-libp2p-kad-dht@v0.16.0

* rename "cid format --codec" to "cid format --mc"

* refactor(test): from --codec to --mc

Co-authored-by: Marcin Rataj <lidel@lidel.org>
(cherry picked from commit 8d7ed00)
guseggert added a commit that referenced this pull request Jun 8, 2022
* feat: upgrade to go-libp2p-kad-dht@v0.16.0

* rename "cid format --codec" to "cid format --mc"

* refactor(test): from --codec to --mc

Co-authored-by: Marcin Rataj <lidel@lidel.org>
(cherry picked from commit 8d7ed00)
guseggert added a commit that referenced this pull request Jun 8, 2022
* feat: upgrade to go-libp2p-kad-dht@v0.16.0

* rename "cid format --codec" to "cid format --mc"

* refactor(test): from --codec to --mc

Co-authored-by: Marcin Rataj <lidel@lidel.org>
(cherry picked from commit 8d7ed00)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants