fix: report gateway http metrics only when response is successful #8827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
lidel
approved these changes
Apr 6, 2022
| // Update metrics | ||
| i.rawBlockGetMetric.WithLabelValues(contentPath.Namespace()).Observe(time.Since(begin).Seconds()) | ||
| // Was response successful? | ||
| if code/100 == 2 && err == nil { |
There was a problem hiding this comment.
💭
This also ignores 304 Not Modified responses when calculating metrics – i think that was intentional, because those also lower response times, right?
Would it be useful to add a global metric counting 304s, just to know the % of "skipped" responses? (in separate PR)
This fix ensures we don't do any additional work when Etag match what user already has in their own cache.
|
@lidel you can merge this whenever. I reran CI to fix a flake. |
xrazis
pushed a commit
to xrazis/kubo
that referenced
this pull request
Apr 14, 2022
* fix: report gateway http metrics only when response is successful * fix(gw): 304 Not Modified as no-op This fix ensures we don't do any additional work when Etag match what user already has in their own cache. Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8820