Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Recognize Go Beta versions in makefile #8677

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix(build): Recognize Go Beta versions in makefile #8677

merged 2 commits into from
Feb 15, 2022

Conversation

NatoBoram
Copy link
Contributor

@NatoBoram NatoBoram commented Jan 14, 2022

This allows using make install with beta versions of Golang.

go-ipfs version: 0.13.0-dev-653dbff13-dirty
Repo version: 12
System version: amd64/linux
Golang version: devel go1.18-becaeea119 Tue Dec 14 17:43:51 2021 +0000

@welcome
Copy link

welcome bot commented Jan 14, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@NatoBoram NatoBoram changed the title fix(build) Recognize Go Beta versions in makefile fix(build): Recognize Go Beta versions in makefile Jan 18, 2022
@guseggert guseggert merged commit ef63822 into ipfs:master Feb 15, 2022
@NatoBoram NatoBoram deleted the bugfix/go-beta branch February 16, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_go_version fails to match Go beta versions
2 participants