Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: badger in config.md #8662

Merged
merged 2 commits into from
Jan 28, 2022
Merged

docs: badger in config.md #8662

merged 2 commits into from
Jan 28, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 11, 2022

This PR updates docs with current status of badger,
which should fix the issue of users thinking badger is "no-brainer faster choice for repos bigger than 10GB"

...and then running into problems.

TODO

flatfs.
- This datastore uses up to several gigabytes of memory.
`flatfs`.
- This datastore uses up to several gigabytes of memory.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should give some examples of repo sizes at which the memory consumption degrades to the point of being useless, so people have a better idea if it even makes sense for their use case.

Anecdotal evidence: ipfs/distributed-wikipedia-mirror#85
Do we have more data on this?

@lidel
Copy link
Member Author

lidel commented Jan 25, 2022

@johnnymatthews mind taking a quick look at markdown changes here? (only 15 lines)

Copy link
Contributor

@johnnymatthews johnnymatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor edits, but I'm fine with them not being committed before merge. They're mainly just formatting and sentence structure.

docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
lidel and others added 2 commits January 28, 2022 22:57
This should fix the issue of users thinking badger
is "no-brainer faster choice" and then running into problems.
Co-authored-by: Johnny <9611008+johnnymatthews@users.noreply.github.com>
@lidel
Copy link
Member Author

lidel commented Jan 28, 2022

Thanks! The company behind badger is closing (https://discuss.dgraph.io/t/quitting-dgraph-labs/16702) so I'm merging this so our new users are not baited into trying badger.

@lidel lidel merged commit 4ad3168 into master Jan 28, 2022
@lidel lidel deleted the docs/update-badger-notes branch January 28, 2022 22:22
lidel added a commit to ipfs/go-ipfs-config that referenced this pull request Jan 28, 2022
This is copy-paste from ipfs/kubo#8662
to ensure consistency.
lidel added a commit to ipfs/go-ipfs-config that referenced this pull request Jan 28, 2022
This is copy-paste from ipfs/kubo#8662
to ensure consistency.
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
This is copy-paste from ipfs#8662
to ensure consistency.
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants