Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove some deprecated calls #8296

Merged
merged 1 commit into from
Aug 13, 2021
Merged

fix: remove some deprecated calls #8296

merged 1 commit into from
Aug 13, 2021

Conversation

Stebalien
Copy link
Member

No description provided.

@@ -50,7 +50,7 @@ func LogOption() ServeOption {
w.WriteHeader(200)
wnf, errs := newWriteErrNotifier(w)
lwriter.WriterGroup.AddWriter(wnf)
log.Event(n.Context(), "log API client connected") //nolint deprecated
log.Info("log API client connected")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently we still need this...

grep "log API client connected" log_out

fails.

I thought we were sending events here now...

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm me, not sure what to make of the logging change though.

@BigLep
Copy link
Contributor

BigLep commented Aug 13, 2021

@Stebalien : will you update the logging or adjust the test so this passes?

@BigLep BigLep added the need/author-input Needs input from the original author label Aug 13, 2021
@Stebalien
Copy link
Member Author

I've reversed the change for now.

@Stebalien
Copy link
Member Author

CI is broken due to ipfs/go-ipfs-api#248.

@Stebalien Stebalien merged commit 34be171 into master Aug 13, 2021
@Stebalien Stebalien deleted the fix/deprecated branch August 13, 2021 21:43
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants