Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional migration APIs #8153

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Conversation

gammazero
Copy link
Contributor

Expose migration APIs for reading migration config and creating migration fetchers. This allows the implementation of commands and external applications that want to retrieve migrations according to the Migration portion of the IPFS config.

This change also moves some functionality that is specific to fetching migrations via IPFS into the ipfsfetcher package.

This PR is also a prerequisite for expanding the functionality of #7658

Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take this is mostly moving things around and apart from the comment below I do no see anything problematic. Also note that this is not code I'm familiar with, but it does not seem to change much anyways.

cmd/ipfs/daemon.go Show resolved Hide resolved
@gammazero
Copy link
Contributor Author

gammazero commented Jun 24, 2021

@hsanjuan This PR is really just moving things around, to make them accessible for doing things like #7658. I have added a comment in the code to offer an explanation for the confusing construct you pointed out, but if you have any suggestions about a better way to do this (given the explanation) I would love to improve that code.

Expose migration APIs for reading migration config and creating migration fetchers.  This allows implementation of commands and external applications that want to retrieve migrations according to the Migration portion of the IPFS config.

This change also moves some functionality that is specific to fetching migrations via IPFS into the `ipfsfetcher` package.
@gammazero
Copy link
Contributor Author

bump

@mvdan mvdan assigned masih and unassigned mvdan Jul 22, 2021
repo/fsrepo/migrations/ipfsfetcher/ipfsfetcher_test.go Outdated Show resolved Hide resolved
repo/fsrepo/migrations/ipfsfetcher/ipfsfetcher_test.go Outdated Show resolved Hide resolved
repo/fsrepo/migrations/migrations_test.go Outdated Show resolved Hide resolved
repo/fsrepo/migrations/migrations.go Show resolved Hide resolved
@aschmahmann aschmahmann merged commit 3b6f577 into master Jul 30, 2021
@aschmahmann aschmahmann deleted the chore/expose-migration-api branch July 30, 2021 18:27
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants