programmatic shell completions #8043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/completions
branch
2 times, most recently
from
9052c4e
to
d1e54d3
Compare
|
So... an alternative would be to add a "complete me" command to go-ipfs so you could pass |
mvdan
reviewed
Jul 1, 2021
| }) | ||
| sort.Slice(parsed.ShortOptions, func(i, j int) bool { | ||
| return parsed.ShortOptions[i] < parsed.ShortOptions[j] | ||
| }) |
There was a problem hiding this comment.
you can use sort.Strings for all four of these
|
Nothing stands out to me with the shell, but I haven't properly reviewed it - I've never written completion scripts by hand :) |
ribasushi
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Generally looks great, excellent work!!!!
A bit annoying that the indentation of the various blocks is all over the place / makes it hard to reason about at first look, but this is not really for human consumption anyway.
Left a single suggestion in the "how to use this" section, good to ship as is without considering it.
Stebalien
force-pushed
the
feat/completions
branch
from
d1e54d3
to
7940371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are missing some of the features of the current hand-rolled completions, but they:
fixes #4551
fixes #8033