build: ignore generated files in changelog #7712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aschmahmann any reason not to merge this? |
aschmahmann
force-pushed
the
fix/ignore-generated-files
branch
from
f3d0bd6
to
0bd3b6e
Compare
aschmahmann
force-pushed
the
fix/ignore-generated-files
branch
from
ad7c600
to
502b68c
Compare
|
@Stebalien it wasn't really working before. I tried these changes out today and they seemed to help a bunch probably ready to merge now unless you can think of more file names to throw in here. |
Stebalien
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add in asset related files from go-libp2p-asn-utils