Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): add silent option for command repo gc #7147

Merged
merged 3 commits into from
Feb 18, 2022
Merged

feat(cmd): add silent option for command repo gc #7147

merged 3 commits into from
Feb 18, 2022

Conversation

will7200
Copy link
Contributor

closes #7129

@ribasushi
Copy link
Contributor

@will7200 this is great 🤩
Would you be able to add some tests that silence indeed takes place? Something like https://github.com/ipfs/go-ipfs/blob/5ecf44a88/test/sharness/t0080-repo.sh#L18-L34 but comparing the ..._actual with /dev/null instead.

To run a test locally you do:

make test_sharness_deps
cd test/sharness
bash the-test-you-want-to-run.sh

Thanks!

P.S. ignore the current test failures you received, we are looking into them...

@will7200 will7200 force-pushed the feat/cmds/repoGC-silent-option branch from e55ca79 to e3fdc5a Compare April 13, 2020 18:34
@will7200
Copy link
Contributor Author

@ribasushi
I added the test case. Let me know if this is sufficient or should be expanded on.

ribasushi
ribasushi approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@Stebalien the test failure on http client is unrelated, something that started happening this weekend :/

@hsanjuan hsanjuan mentioned this pull request Apr 14, 2020
Closed
@lidel lidel self-requested a review February 18, 2022 16:44
@lidel lidel force-pushed the feat/cmds/repoGC-silent-option branch from d17faf9 to 43459c9 Compare February 18, 2022 17:57
@lidel
fix: no emit on server with --silent
85e8bfb 
This removes unnecessary send to the client that does not care
lidel
lidel approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than never! 🙃

@lidel lidel merged commit bfa9d3d into ipfs:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@ribasushi ribasushi ribasushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipfs repo gc --quiet is not quiet
3 participants
@will7200 @ribasushi @lidel