Add programatic defaults #2484
Closed
Add programatic defaults #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardLitt
added
RFCR
need/review
RichardLitt
force-pushed
the
feature/add-defaults
branch
from
6edd90a
to
b691e17
Compare
| @@ -22,7 +22,7 @@ Lists running and recently run commands. | |||
| res.SetOutput(req.InvocContext().ReqLog.Report()) | |||
| }, | |||
| Options: []cmds.Option{ | |||
| cmds.BoolOption("v", "verbose", "print more verbose output"), | |||
| cmds.BoolOption("v", "verbose", "print more verbose output").Default(false), | |||
There was a problem hiding this comment.
Is it necessary to add Default(false) to every boolean option? I think it can be inferred that the default value is false.
There was a problem hiding this comment.
They're not always false. We could specify only when default is true? cc @jbenet
There was a problem hiding this comment.
Going to assume that yes, we should add Default(false) from now on. See #2582 (comment)
RichardLitt
removed
exp/expert
RichardLitt
force-pushed
the
feature/add-defaults
branch
2 times, most recently
from
88459aa
to
6b2f4f2
Compare
|
@RichardLitt ping. |
RichardLitt
force-pushed
the
feature/add-defaults
branch
from
6b2f4f2
to
c06c696
Compare
RichardLitt
added a commit
that referenced
this pull request
May 12, 2016
Specifically, to `repo`, `resolve`, `swarm`, and `version`. Part of #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 12, 2016
Not sure about the switch statement. There may be a more elegant solution. Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 14, 2016
Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 14, 2016
Added Default logic per #2484, and also added the local option back in, because it exists in the code and should be shown as helptext, at least. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 14, 2016
Not sure about the switch statement. There may be a more elegant solution. Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 14, 2016
Part of #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 14, 2016
Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 15, 2016
Split from #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 15, 2016
Split from #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Kubuxu
pushed a commit
that referenced
this pull request
May 17, 2016
Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 18, 2016
I didn't bother with Chunker, because I think that is a much wider PR. These should all be solid, though. Redid some of the logic to make it smoother. Part of #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 18, 2016
Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 19, 2016
Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Kubuxu
pushed a commit
that referenced
this pull request
May 19, 2016
Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com> and License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
added a commit
that referenced
this pull request
May 19, 2016
Part of #2484 License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
pushed a commit
that referenced
this pull request
May 19, 2016
I didn't bother with Chunker, because I think that is a much wider PR. These should all be solid, though. Redid some of the logic to make it smoother. Part of #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Kubuxu
pushed a commit
that referenced
this pull request
May 19, 2016
I didn't bother with Chunker, because I think that is a much wider PR. These should all be solid, though. Redid some of the logic to make it smoother. Part of #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
added a commit
that referenced
this pull request
May 21, 2016
I didn't bother with Chunker, because I think that is a much wider PR. These should all be solid, though. Redid some of the logic to make it smoother. Part of #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed up a few spelling errors and mistypes, here and there. Got everything I could find.
License: MIT
Signed-off-by: Richard Littauer richard.littauer@gmail.com