diff --git a/impl/graphsync_test.go b/impl/graphsync_test.go index 3b5d1341..141d0341 100644 --- a/impl/graphsync_test.go +++ b/impl/graphsync_test.go @@ -378,8 +378,6 @@ func TestGraphsyncRoundTrip(t *testing.T) { "request(0)->terminateRequest(0)", }, tracing.TracesToStrings()) processUpdateSpan := tracing.FindSpanByTraceString("response(0)") - require.False(t, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "isUpdate").AsBool()) - require.False(t, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "isCancel").AsBool()) require.Equal(t, int64(0), testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "priority").AsInt64()) require.Equal(t, []string{string(td.extensionName)}, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "extensions").AsStringSlice()) } @@ -818,9 +816,6 @@ func TestPauseResumeViaUpdate(t *testing.T) { }, tracing.TracesToStrings()) // make sure the attributes are what we expect processUpdateSpan := tracing.FindSpanByTraceString("response(0)->processUpdate(0)") - require.True(t, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "isUpdate").AsBool()) - require.False(t, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "isCancel").AsBool()) - require.Equal(t, int64(0), testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "priority").AsInt64()) require.Equal(t, []string{string(td.extensionName)}, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "extensions").AsStringSlice()) // pause recorded tracing.SingleExceptionEvent(t, "response(0)->executeTask(0)", "github.com/ipfs/go-graphsync/responsemanager/hooks.ErrPaused", hooks.ErrPaused{}.Error(), false) @@ -904,9 +899,6 @@ func TestPauseResumeViaUpdateOnBlockHook(t *testing.T) { }, tracing.TracesToStrings()) // make sure the attributes are what we expect processUpdateSpan := tracing.FindSpanByTraceString("response(0)->processUpdate(0)") - require.True(t, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "isUpdate").AsBool()) - require.False(t, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "isCancel").AsBool()) - require.Equal(t, int64(0), testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "priority").AsInt64()) require.Equal(t, []string{string(td.extensionName)}, testutil.AttributeValueInTraceSpan(t, *processUpdateSpan, "extensions").AsStringSlice()) // pause recorded tracing.SingleExceptionEvent(t, "response(0)->executeTask(0)", "github.com/ipfs/go-graphsync/responsemanager/hooks.ErrPaused", hooks.ErrPaused{}.Error(), false) diff --git a/responsemanager/server.go b/responsemanager/server.go index 21bd03c1..388cbc16 100644 --- a/responsemanager/server.go +++ b/responsemanager/server.go @@ -66,10 +66,6 @@ func (rm *ResponseManager) processUpdate(key responseKey, update gsmsg.GraphSync _, span := otel.Tracer("graphsync").Start(trace.ContextWithSpan(rm.ctx, response.span), "processUpdate", trace.WithAttributes( attribute.Int("id", int(update.ID())), - attribute.Int("priority", int(update.Priority())), - attribute.String("root", update.Root().String()), - attribute.Bool("isCancel", update.IsCancel()), - attribute.Bool("isUpdate", update.IsUpdate()), attribute.StringSlice("extensions", update.ExtensionNames()), )) defer span.End() @@ -186,8 +182,6 @@ func (rm *ResponseManager) processRequests(p peer.ID, requests []gsmsg.GraphSync attribute.Int("id", int(request.ID())), attribute.Int("priority", int(request.Priority())), attribute.String("root", request.Root().String()), - attribute.Bool("isCancel", request.IsCancel()), - attribute.Bool("isUpdate", request.IsUpdate()), attribute.StringSlice("extensions", request.ExtensionNames()), )) rm.connManager.Protect(p, request.ID().Tag())