This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
WIP Files #8
Closed
WIP Files #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Path, String format path to a file to be added to IPFS | ||
| - Object, with format `{ path: </foo/bar>, stream: <data> }` | ||
| - Array, an [array] of objects with the above format. | ||
|
|
There was a problem hiding this comment.
there is also the option that no 1st arg is passed, a duplex stream is returned
|
This is s great start! Thank you @nginnever :D |
|
|
||
| - `Recursive`. Add directory paths recursively. | ||
|
|
||
| `callback` must follow `function (err, object) {}` signature, where `err` is an error if the operation was not successful and `object` is an ndjson return with properties { Name (string), Hash (multihash) } |
There was a problem hiding this comment.
What is "an ndjson return"?
|
There is a lot of great activity and we are really close of having add, cat and get in both js-ipfs and js-ipfs-api with the same API, which is great. @noffle @nginnever, let's set this as a priority for the day, as we need ipfs cat to unlock @haadcode. What is missing
|
|
@nginnever is this PR still up to date? |
|
hey @diasdavid, no this is dated and should be closed.
|
|
@nginnever thank you for confirming :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning the files documentation. I haven't added the tests yet but plan to do so after finishing the HTTP-API for JS-IPFS. There are still some things that need to be done to reach complete feature parity with go-ipfs but this is a good place to put the documentation of where js-ipfs is in comparison.
Starting the gzip compression and tar archiving for jsipfs get command as mentioned in the readme update here.