Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

config API #39

Merged
merged 1 commit into from
Jul 2, 2016
Merged

config API #39

merged 1 commit into from
Jul 2, 2016

Conversation

daviddias
Copy link
Contributor

@daviddias daviddias commented Jun 30, 2016

@daviddias daviddias changed the title Init config API config API Jun 30, 2016
@daviddias daviddias force-pushed the config-api branch 12 times, most recently from 2803c66 to 0a0aa4a Compare July 1, 2016 17:08
@daviddias
Copy link
Contributor Author

@xicombd, @dignifiedquire, @victorbjelkholm, @nginnever, @noffle, @haadcode, @xicombd would you like to CR this PR and the two related? Namely:

Other then the hickup on go-ipfs config replace command (ipfs/kubo#2927), it is should be good for the merge :)

})
})

it('set a json object', (done) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON

@RichardLitt
Copy link
Contributor

Tried testing; was unable to get the tests to run. The instructions in the Readme weren't clear on how to do this for this module only.

Otherwise, LGTM.

@dignifiedquire
Copy link
Contributor

Tried testing; was unable to get the tests to run. The instructions in the Readme weren't clear on how to do this for this module only.

The tests can not be run on them own, they need to be integrated into an implementation. See js-ipfs and js-ipfs-api tests for how that looks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants