render optional args as ?name: type instead of name: option<type>

[dawedawe]

before:

after:

We already do this in the status bar of VsCode/Ionide.
The line lens is still wrong, but one thing at a time :)

[baronfel]

LGTM, but I had a nit and I'd love to see a test to ensure we don't regress this.

[baronfel]

Looks like we do have a test: FSAC.lsp.Ionide WorkspaceLoader.BackgroundCompiler.tooltip evaluation.tests.tooltip for line 48 character 28 should be 'static member Start: body : (MailboxProcessor<string> -> Async<unit>) * cancellationToken: option<System.Threading.CancellationToken> -> MailboxProcessor<string>' - should be easy to update and then we're good to go!

[dawedawe]

LGTM, but I had a nit and I'd love to see a test to ensure we don't regress this.

Yes, sorry. I tried to come up with a test but expecto and me, man, we are no friends.

[dawedawe]

Hey @baronfel , is there anything still missing here?

[baronfel]

Nope, lovely change! Thank you for sending it!

[dawedawe]

Sure, FSAC is absolutely rocking it!