Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-bar): use as standalone in vue #29925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tab-bar): use as standalone in vue #29925

wants to merge 1 commit into from

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Oct 7, 2024

Issue number: resolves #29885


What is the current behavior?

Vue: Tab bar could be a standalone element within ion-tabs and would navigate without issues with a router outlet before v8.3:

<ion-tabs>
  <ion-router-outlet></ion-router-outlet>

  <TabBar></TabBar>
</ion-tabs>

It would work as if it was written as:

<ion-tabs>
  <ion-router-outlet></ion-router-outlet>

  <ion-tab-bar slot="bottom">
    <!-- Buttons -->
  </ion-tab-bar>
</ion-tabs>

After v8.3, any ion-tab-bar that was not a direct child of ion-tabs would lose it's expected behavior when used with a router outlet. If a user clicked on a tab button, then the content would not be redirected to that expected view.

What is the new behavior?

The Vue tab bar's _hasRouterOutlet prop has been modified to accept both Boolean and undefined values. When the value is undefined, it indicates that the ion-tab-bar component was not found within the slotted content of ion-tabs. This typically occurs when the tab bar is not passed as a direct child of ion-tabs.

In such cases, the tab bar will perform its own check to determine if an ion-router-outlet is present. This check cannot be handled by tabs, as it would need to wait until after mounting to access the DOM, which would be too late since the tab bar would have already executed the logic that depends on _hasRouterOutlet.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.3.3-dev.11728341918.1d3d4b3f

How to test:

  1. Clone the issue repro
  2. Navigate to folder 8.3.0-standalone
  3. Install deps
  4. Start app
  5. Click on the tab buttons
  6. Notice the content and URL doesn't change
  7. Install dev build: npm install @ionic/vue@8.3.3-dev.11728341918.1d3d4b3f
  8. Start app
  9. Click on the tab buttons
  10. Verify that the correct content and URL displays

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 10:48pm

@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 7, 2024
@thetaPC thetaPC marked this pull request as ready for review October 7, 2024 23:16
@thetaPC thetaPC requested a review from a team as a code owner October 7, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-tab-bar is not working when used as a standalone Vue component after the v8.3.0/v8.3.1 update
2 participants