Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic Upload changes remote script url #504

Closed
AdamCaviness opened this issue Jun 22, 2015 · 4 comments
Closed

Ionic Upload changes remote script url #504

AdamCaviness opened this issue Jun 22, 2015 · 4 comments
Assignees

Comments

@AdamCaviness
Copy link

Ionic Upload mutates a remote script url by suffixing it with an equals sign.

<script src="http://jsconsole.com/remote.js?FAE031CD-74A0-46D3-AE36-757BAB262BEA"></script>

Is mutated to:

<script src="http://jsconsole.com/remote.js?FAE031CD-74A0-46D3-AE36-757BAB262BEA="></script>

I am using remotejs.com for Ionic View so I need the remote script (dev only). It's annoying because I have to change it back each time in order for my next upload not to send the wrong script path. I presume this is because of how the paths are changed temporarily during Upload and then reverted. This is easy to reproduce on a clean tab templated app from the machines I attempted it on. Thanks for the wonderful work you've done, it is very impressive.

@jbavari jbavari self-assigned this Jun 29, 2015
@jbavari
Copy link

jbavari commented Jun 29, 2015

We'll look into it. Thanks for reporting.

@jbavari
Copy link

jbavari commented Jun 30, 2015

@AdamCaviness I've got a fix for this in place here: ionic-team/ionic-app-lib@a3cbc85

@AdamCaviness
Copy link
Author

@jbavari Thanks for addressing this.

@jbavari
Copy link

jbavari commented Jul 3, 2015

Fixed in 1.6.0.

@jbavari jbavari closed this as completed Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants