Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: cleanup Isolate::GetCurrent() #807

Closed
wants to merge 1 commit into from

Conversation

vkurchatkin
Copy link
Contributor

@bnoordhuis
Copy link
Member

LGTM FWIW

@trevnorris
Copy link
Contributor

Great stuff. LGTM.

@bnoordhuis on the C++ side, your opinion is always worth more than mine. ;-)

trevnorris pushed a commit to trevnorris/node that referenced this pull request Feb 11, 2015
PR-URL: nodejs#807
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@trevnorris
Copy link
Contributor

Thanks. Landed in 8aed9d6.

@trevnorris trevnorris closed this Feb 11, 2015
@vkurchatkin
Copy link
Contributor Author

@trevnorris can't see it. you probably pushed to the wrong remote :)

@vkurchatkin
Copy link
Contributor Author

pushed it myself, still 8aed9d6

@trevnorris
Copy link
Contributor

@vkurchatkin thanks. yeah, wrong remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants