Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix leak in SafeX509ExtPrint #1087

Closed
wants to merge 1 commit into from
Closed

crypto: fix leak in SafeX509ExtPrint #1087

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Mar 7, 2015

ASN1_item_d2i's return value must be freed by the owner.

@indutny
crypto: fix leak in SafeX509ExtPrint
5b57d60 
`ASN1_item_d2i`'s return value must be freed by the owner.
@indutny
Copy link
Member Author

indutny commented Mar 7, 2015

cc @iojs/crypto

@bnoordhuis
Copy link
Member

LGTM

indutny added a commit that referenced this pull request Mar 7, 2015
@indutny
crypto: fix leak in SafeX509ExtPrint
3b57819 
`ASN1_item_d2i`'s return value must be freed by the owner.

Fix: #1075
PR-URL: #1087
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@indutny
Copy link
Member Author

indutny commented Mar 7, 2015

Landed in 3b57819, thank you!

@indutny indutny closed this Mar 7, 2015
@indutny indutny deleted the fix/leak-in-get-peer-cert branch March 7, 2015 13:22
@rvagg rvagg mentioned this pull request Mar 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indutny @bnoordhuis