fix: before_first_request deprecation #171
Conversation
invenio_administration/views/base.py
Outdated
| @@ -259,8 +260,7 @@ def get_context(self, pid_value=None): | |||
| serialized_schema = self._schema_to_json(schema) | |||
| fields = self.item_field_list | |||
| return { | |||
| "request_headers" | |||
| "name": name, | |||
| "request_headers" "name": name, | |||
There was a problem hiding this comment.
That looks like a bug actually 😅
@kpsherva (or anyone familiar), can you verify?
There was a problem hiding this comment.
Not a big fan of introducing a new filename convention for these type of functions. Could we maybe instead leave these functions ext.py?
There was a problem hiding this comment.
if i move all what it is now in finalize_app.py should i keep the function structure the same. so one function def finalize_app as the entrypoint within the ext.py file?
There was a problem hiding this comment.
Yeah, I think splitting into multiple entrypoints doesn't achieve anything, so one big function calling smaller functions doing their thing, looks like the way to go. Then the entrypoint is just pointing to invenio_administration.ext:finalize_app.
utnapischtim
force-pushed
the
add-init-function
branch
from
e3d0b3f
to
6221022
Compare
utnapischtim
force-pushed
the
add-init-function
branch
from
6221022
to
13b3468
Compare
* the deprecation warning has been fixed by using the new entry_point invenio_base.finalize_app
utnapischtim
force-pushed
the
add-init-function
branch
from
13b3468
to
bdb28bd
Compare
* the problem was that the mock fixtures were called after the app creation. this does not work because in the finalize_app they have to be ready already. therefore they are now called as a entry point before of the finalize_app
utnapischtim
force-pushed
the
add-init-function
branch
from
6342ce4
to
9c1307b
Compare
* invenio-accounts, invenio-theme, invenio-base, invenio-app
utnapischtim
force-pushed
the
add-init-function
branch
from
9c1307b
to
e30eb31
Compare
No description provided.