-
Notifications
You must be signed in to change notification settings - Fork 31
/
test_invenio_admin.py
340 lines (272 loc) · 11.1 KB
/
test_invenio_admin.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
# -*- coding: utf-8 -*-
#
# This file is part of Invenio.
# Copyright (C) 2015-2018 CERN.
# Copyright (C) 2022 RERO.
#
# Invenio is free software; you can redistribute it and/or modify it
# under the terms of the MIT License; see LICENSE file for more details.
"""Module tests."""
import importlib
from unittest.mock import patch
import flask_admin
import importlib_metadata
import pytest
from flask import Flask
from flask_admin.contrib.sqla import ModelView
from importlib_metadata import EntryPoint
from invenio_access.permissions import Permission
from invenio_db import db
from invenio_theme import InvenioTheme
from invenio_admin import InvenioAdmin
from invenio_admin.permissions import admin_permission_factory
from invenio_admin.views import protected_adminview_factory
def test_version():
"""Test version import."""
from invenio_admin import __version__
assert __version__
def test_init():
"""Test extension initialization."""
app = Flask("testapp")
ext = InvenioAdmin(app)
assert "invenio-admin" in app.extensions
app = Flask("testapp")
ext = InvenioAdmin()
assert "invenio-admin" not in app.extensions
ext.init_app(app)
assert "invenio-admin" in app.extensions
def test_invenio_theme_loading_order():
"""Test base template set correctly by invenio_theme."""
app = Flask("testapp")
InvenioAdmin(app)
assert app.config.get("ADMIN_BASE_TEMPLATE") is None
app = Flask("testapp")
InvenioTheme(app)
InvenioAdmin(app)
assert app.config.get("ADMIN_BASE_TEMPLATE") is not None
app = Flask("testapp")
InvenioAdmin(app)
InvenioTheme(app)
assert app.config.get("ADMIN_BASE_TEMPLATE") is not None
def test_base_template_override():
"""Test base template is set up correctly."""
app = Flask("testapp")
base_template = "test_base_template.html"
app.config["ADMIN_BASE_TEMPLATE"] = base_template
InvenioTheme(app)
state = InvenioAdmin(app)
assert app.config.get("ADMIN_BASE_TEMPLATE") == base_template
# Force call of before_first_request registered triggers.
app.try_trigger_before_first_request_functions()
assert state.admin.base_template == base_template
def test_default_permission(app):
"""Test loading of default permission class."""
with app.app_context():
with patch("importlib_metadata.version") as get_distribution:
get_distribution.side_effect = importlib_metadata.PackageNotFoundError
assert not isinstance(admin_permission_factory(None), Permission)
assert isinstance(admin_permission_factory(None), Permission)
def test_admin_view_authenticated(app):
"""Test the authentication for the admin."""
with app.test_client() as client:
res = client.get("/admin/", follow_redirects=False)
# Assert redirect to login
assert res.status_code == 302
# Unauthenticated users are redirect to login page.
with app.test_client() as client:
# Model view
res = client.get("/admin/testmodel/", follow_redirects=False)
assert res.status_code == 302
assert res.location.startswith("/login")
# Base view
res = client.get("/admin/testbase/")
assert res.status_code == 302
assert res.location.startswith("/login")
res = client.get("/admin/testbase/foo/")
assert res.status_code == 302
assert res.location.startswith("/login")
# User 1 can access admin because it has ActioNeed(admin-access)
with app.test_client() as client:
res = client.get("/login/?user=1")
assert res.status_code == 200
# Admin panel
res = client.get("/admin/")
assert res.status_code == 200
# Model view
res = client.get("/admin/testmodel/")
assert res.status_code == 200
# Base view
res = client.get("/admin/testbase/")
assert res.status_code == 200
res = client.get("/admin/testbase/foo/")
assert res.status_code == 200
# User 2 is missing ActioNeed(admin-access) and thus can't access admin.
# 403 error returned.
with app.test_client() as client:
res = client.get("/login/?user=2")
# Admin panel
res = client.get("/admin/")
assert res.status_code == 403
# Model view
res = client.get("/admin/testmodel/")
assert res.status_code == 403
# Base view
res = client.get("/admin/testbase/")
assert res.status_code == 403
res = client.get("/admin/testbase/foo/")
assert res.status_code == 403
def test_menu_visiblity(app):
"""Test menu visiblity."""
@app.route("/menu/")
def render_menu():
settings_menu = app.extensions["menu"].submenu("settings")
return ";".join([i.url for i in settings_menu.children if i.visible])
with app.test_client() as client:
res = client.get("/menu/")
assert "/admin/" not in res.get_data(as_text=True)
res = client.get("/login/?user=1")
assert res.status_code == 200
res = client.get("/menu/")
assert "/admin/" in res.get_data(as_text=True)
def test_custom_permissions(app, testmodelcls):
"""Test custom permissions."""
class CustomModel(testmodelcls):
"""Some custom model."""
pass
class CustomView(ModelView):
"""Some custom model."""
@staticmethod
def is_accessible():
"""Check if accessible."""
return False
protected_view = protected_adminview_factory(CustomView)
app.extensions["admin"][0].add_view(protected_view(CustomModel, db.session))
with app.test_client() as client:
res = client.get("/login/?user=1")
assert res.status_code == 200
res = client.get("/admin/")
assert res.status_code == 200
res = client.get("/admin/testmodel/")
assert res.status_code == 200
res = client.get("/admin/testbase/")
assert res.status_code == 200
res = client.get("/admin/custommodel/")
assert res.status_code == 403
class MockEntryPoint(EntryPoint):
"""Mock of EntryPoint."""
def load(self):
"""Mock the load of entry point."""
mod = importlib.import_module(self.module)
obj = getattr(mod, self.name)
return obj
def _mock_iter_entry_points():
"""Mock the entry point iterator."""
def fn(group=None):
entry_points = {
"invenio_admin.views_invalid": [
MockEntryPoint(
name="zero",
value="demo.onetwo",
group="invenio_admin.views_invalid",
),
],
"invenio_admin.views": [
MockEntryPoint(
name="one", value="demo.onetwo", group="invenio_admin.views"
),
MockEntryPoint(
name="two", value="demo.onetwo", group="invenio_admin.views"
),
MockEntryPoint(
name="three", value="demo.three", group="invenio_admin.views"
),
MockEntryPoint(
name="four", value="demo.four", group="invenio_admin.views"
),
],
}
if group:
entry_points_group = []
for eps in entry_points.values():
for ep in eps:
if ep.group == group:
entry_points_group.append(ep)
return entry_points_group
return entry_points
return fn
@patch("importlib_metadata.entry_points", _mock_iter_entry_points())
def test_invalid_entry_points():
"""Test invalid admin views discovery through entry points."""
app = Flask("testapp")
admin_app = InvenioAdmin()
with pytest.raises(Exception) as e:
admin_app.init_app(app, entry_point_group="invenio_admin.views_invalid")
assert '"view_class"' in str(e)
@patch("importlib_metadata.entry_points", _mock_iter_entry_points())
def test_entry_points():
"""Test admin views discovery through entry points."""
from flask_principal import Permission
app = Flask("testapp")
admin_app = InvenioAdmin(
app, permission_factory=lambda x: Permission(), view_class_factory=lambda x: x
)
# Check if model views were added by checking the labels of menu items
menu_items = {str(item.name): item for item in admin_app.admin.menu()}
assert "OneAndTwo" in menu_items # Category for ModelOne and ModelTwo
assert "Four" in menu_items # Category for ModelOne and ModelTwo
assert "Model One" not in menu_items # ModelOne should go to a category
assert "Model Two" not in menu_items # ModelTwo should go to a category
assert "Model Three" in menu_items # ModelThree goes straight to menu
assert isinstance(menu_items["Model Three"], flask_admin.menu.MenuView)
assert isinstance(menu_items["OneAndTwo"], flask_admin.menu.MenuCategory)
assert menu_items["OneAndTwo"].is_category()
assert not menu_items["Model Three"].is_category()
submenu_items = {
str(item.name): item for item in menu_items["OneAndTwo"].get_children()
}
assert "Model One" in submenu_items
assert "Model Two" in submenu_items
assert not submenu_items["Model One"].is_category()
assert not submenu_items["Model Two"].is_category()
assert isinstance(submenu_items["Model One"], flask_admin.menu.MenuView)
assert isinstance(submenu_items["Model Two"], flask_admin.menu.MenuView)
four_item = menu_items["Four"].get_children()[0]
assert four_item.name == "View number Four"
assert isinstance(four_item, flask_admin.menu.MenuView)
def test_talisman_csp_config_overridden(app):
"""Test that the CSP config of Talisman is set to None."""
class OldTalisman:
"""Fake Old Talisman class."""
def __init__(self):
from werkzeug.local import Local
self.local_options = Local()
setattr(
self.local_options, "content_security_policy", "'default-src': ''self'"
)
class NewTalisman:
"""Fake New Talisman class."""
def __init__(self):
self.content_security_policy = "'default-src': ''self'"
class InvenioApp:
"""Fake Invenio App class."""
def __init__(self, talisman):
print("ciao")
self.talisman = talisman
app.extensions["invenio-app"] = InvenioApp(OldTalisman())
invenio_app = app.extensions["invenio-app"]
assert invenio_app.talisman.local_options.content_security_policy
with app.test_client() as client:
res = client.get("/login/?user=1")
assert res.status_code == 200
res = client.get("/admin/")
assert res.status_code == 200
assert not invenio_app.talisman.local_options.content_security_policy
app.extensions["invenio-app"] = InvenioApp(NewTalisman())
invenio_app = app.extensions["invenio-app"]
assert invenio_app.talisman.content_security_policy
with app.test_client() as client:
res = client.get("/login/?user=1")
assert res.status_code == 200
res = client.get("/admin/")
assert res.status_code == 200
assert not invenio_app.talisman.content_security_policy