Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with "cookie-session" #41

Closed
pensierinmusica opened this issue Jun 24, 2014 · 8 comments
Closed

Conflict with "cookie-session" #41

pensierinmusica opened this issue Jun 24, 2014 · 8 comments

Comments

@pensierinmusica
Copy link

Please see expressjs/cookie-session#14

Thanks!

@andineck
Copy link
Member

You are right, this is something that needs to be fixed in connect-livereload. cookie-session and connect-livereload both overwrite the http writeHead function. connect-livereload in this version loads the original function back after it is done, and therefore overwrites the (extended version by cookie-session) when it was loaded before connect-livereload.

Needs to be changed...

In the meantime load the cookie-session middleware after connect-livereload.

@kennu
Copy link

kennu commented Jul 31, 2014

I am also having this problem with express-session and it seems to be fixed by moving connect-livereload to the end of all middlewares.

@Fishrock123
Copy link

As doug mentioned in the cookie-session thread, the lines in question are index.js L94-L98.

@joshperry
Copy link
Contributor

Happy to spend some time on this issue, considering it wasted almost a day for me already. Anyone have a good strategy in mind for fixing this issue?

@andineck
Copy link
Member

@joshperry : Can you test if branch binary-files works well together with cookie-session?
The restore() function has been removed in this version. A unit test for this would be welcome too :-)

@joshperry
Copy link
Contributor

@andi-neck Yeah, let me give it a try.

@joshperry
Copy link
Contributor

When using that branch, livereload does not interfere with the session anymore, but the livereload functionality doesn't work either.

The livereload websocket connects properly and the info and hello frames are sent, but no frames are sent when I change a file.

@andineck
Copy link
Member

pushed to npm v0.5.2, thx to @joshperry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants