travis ci build fails due to linting errors ?

[tabshaikh]

Description

What problem are we solving? What does the experience look like today? What are the symptoms?
We use Stylelint which gives us protection from various CSS issues, so if the pr doesn't follow the linting rules of the css the travis build fails.

Evidence

The travis error log will look something like this ->

[tabshaikh]

Answer
To fix the build failure due to linting errors in the local dev we may want to change all the statements that violate the linting rules. This can be done by running npm run lint:fix inside the docker container which will fix show all the css files with the rule violations which may have to be manually fixed.
To go inside the docker container :
docker-compose exec web bash

[shreyansh23]

I installed open library using using docker, so to check the linting errors I had to do

docker-compose exec web bash
make test

[tabshaikh]

@shreyansh23 i also use docker but i can use the command normally outside too can you confirm?

[shreyansh23]

Yes @tabshaikh I can also run the command outside but to see the errors I had to go inside the container.
Using npm run lint:fix,

Using make test

[tabshaikh]

@shreyansh23 Thanks for the confirmation. Updated my answer, we are trying to build a faq for new contributors where all questions and answers would be stored in this wiki https://github.com/internetarchive/openlibrary/wiki/Beginner's-FAQ. If you have some questions feel free to add them to it :)

[mekarpeles]

This is great! @tabshaikh has linked this question on our wiki -- closing this as an issue :)