Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python checker says something 'is' python when calling guess_contains #445

Closed
terriko opened this issue Mar 3, 2020 · 0 comments
Closed
Labels
good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented Mar 3, 2020

There's a bug on line 69:

https://github.com/intel/cve-bin-tool/blob/master/cve_bin_tool/checkers/python.py#L69

It's guessing if it contains python, but then returns that it "is" python. it should be setting that value to "contains". This is maybe not going to come up much (I suspect people don't compile python directly into things much) but we should still fix it beacuse I don't want someone to copy this anti-pattern when building a new checker.

@terriko terriko added the good first issue Good for newcomers label Mar 3, 2020
@terriko terriko closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant