From 9b87dfdfa3d05e1e224c56800f72489b844a7c9b Mon Sep 17 00:00:00 2001 From: Miklos Suveges Date: Tue, 18 Jan 2022 17:56:51 +0100 Subject: [PATCH 1/2] Increase ticker max length to 6 --- token-metadata-creator/src/Cardano/Metadata/Types.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/token-metadata-creator/src/Cardano/Metadata/Types.hs b/token-metadata-creator/src/Cardano/Metadata/Types.hs index 9a295b7..f6e1518 100644 --- a/token-metadata-creator/src/Cardano/Metadata/Types.hs +++ b/token-metadata-creator/src/Cardano/Metadata/Types.hs @@ -381,7 +381,7 @@ validateMetadataPolicy t = Policy t <$> validateMetadataTicker :: MonadFail f => Text -> f Ticker validateMetadataTicker = fmap Ticker . - (validateMinLength 2 >=> validateMaxLength 5) + (validateMinLength 2 >=> validateMaxLength 6) validateMetadataDescription :: MonadFail f => Text -> f Description validateMetadataDescription = fmap Description . From deaaa96ed3af30102ec0835cb71b7f961093e751 Mon Sep 17 00:00:00 2001 From: Pi Lanningham Date: Wed, 19 Jan 2022 19:24:35 +0000 Subject: [PATCH 2/2] Update readme, max length of 9, and a test --- token-metadata-creator/README.md | 2 +- .../src/Cardano/Metadata/Types.hs | 2 +- token-metadata-creator/test/index.spec.js | 16 ++++++++++++++++ 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/token-metadata-creator/README.md b/token-metadata-creator/README.md index 60ec665..6578f5a 100644 --- a/token-metadata-creator/README.md +++ b/token-metadata-creator/README.md @@ -65,7 +65,7 @@ token-metadata-creator entry 19309eb9c066253cede617dc635223ace320ae0bbdd5bd19684 | Field | Details | Command | | --- | --- | --- | | `policy` | the exact script which hashes to the `policyId` | `--policy \| -p` | -| `ticker` | between 2 and 5 UTF-8 characters | `--ticker \| -t` | +| `ticker` | between 2 and 9 UTF-8 characters | `--ticker \| -t` | | `url` | a valid https URI | `--url \| -h` | | `logo` | a PNG image file | `--logo \| -l` | diff --git a/token-metadata-creator/src/Cardano/Metadata/Types.hs b/token-metadata-creator/src/Cardano/Metadata/Types.hs index f6e1518..b893ccc 100644 --- a/token-metadata-creator/src/Cardano/Metadata/Types.hs +++ b/token-metadata-creator/src/Cardano/Metadata/Types.hs @@ -381,7 +381,7 @@ validateMetadataPolicy t = Policy t <$> validateMetadataTicker :: MonadFail f => Text -> f Ticker validateMetadataTicker = fmap Ticker . - (validateMinLength 2 >=> validateMaxLength 6) + (validateMinLength 2 >=> validateMaxLength 9) validateMetadataDescription :: MonadFail f => Text -> f Description validateMetadataDescription = fmap Description . diff --git a/token-metadata-creator/test/index.spec.js b/token-metadata-creator/test/index.spec.js index 52aaa4f..b973dc7 100644 --- a/token-metadata-creator/test/index.spec.js +++ b/token-metadata-creator/test/index.spec.js @@ -171,6 +171,22 @@ describe("token-metadata-creator", () => { assert.equal(getDraft(alice).decimals.sequenceNumber, 1); }); + + it("Name length [2-9]", () => { + const ticker = `MILKSHAKE`; + + cli(alice, "--ticker", ticker); + + const empty = { sequenceNumber: 0, signatures: [] }; + assert.deepEqual(getDraft(alice).ticker, { ...empty, value: ticker }); + + try { + cli(alice, "--ticker", `${ticker}+`) + assert.fail("should have thrown."); + } catch (e) {} + }) + + it("Edit property on successive calls", () => { let name = "SuperCoin" cli(alice, "--name", "foo");