Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete ICS20 ft-transfer implementation #59

Closed
1 of 9 tasks
hu55a1n1 opened this issue Jan 11, 2022 · 1 comment · Fixed by informalsystems/hermes#1989
Closed
1 of 9 tasks

Complete ICS20 ft-transfer implementation #59

hu55a1n1 opened this issue Jan 11, 2022 · 1 comment · Fixed by informalsystems/hermes#1989
Assignees

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Jan 11, 2022

Crate

ibc

Summary

This is an attempt to gather all requirements for a complete ICS20 implementation.

Problem Definition

type Keeper struct {
        // ...
	ics4Wrapper   types.ICS4Wrapper
	channelKeeper types.ChannelKeeper
	portKeeper    types.PortKeeper
	authKeeper    types.AccountKeeper
	bankKeeper    types.BankKeeper
}

The Keeper must additionally provide helper methods for port-binding, denom-traces, etc.

Proposal

I propose we design an API that doesn't make assumptions on the SDK stack. A detailed proposal can be discussed via a draft PR.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Wizdave97
Copy link

@hu55a1n1 @adizere put up a draft PR for the ICS 20 Keeper, please give a review informalsystems/hermes#1884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants