Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ABCI CheckTx method equivalent for IBC #78

Closed
5 tasks
hu55a1n1 opened this issue Jul 13, 2021 · 0 comments · Fixed by informalsystems/hermes#1203
Closed
5 tasks

Add an ABCI CheckTx method equivalent for IBC #78

hu55a1n1 opened this issue Jul 13, 2021 · 0 comments · Fixed by informalsystems/hermes#1203

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Jul 13, 2021

Crate

ibc

Summary

Add a decode() function that mimics the abci::CheckTx method similar to the deliver() function.

Problem Definition

This would be useful for ABCI applications to determine whether the incoming messages are valid IBC messages.

Proposal

Extract parts of the deliver() function into a separate function that decodes the prost message into a domain type.

Acceptance Criteria

Provide a function that can be used to check if incoming transaction messages are valid IBC messages, and reuse this function in the deliver() function.

pub fn decode(message: Any) -> Result<Ics26Envelope, Error>

Might also be nice to have impl TryFrom<Any> for Ics26Envelope.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 changed the title Add an ABCI CheckTx methods equivalent for IBC Add an ABCI CheckTx method equivalent for IBC Jul 13, 2021
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant