Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the IBC-go team with integrating Hermes into ibctest framework #2961

Closed
2 tasks done
adizere opened this issue Dec 19, 2022 · 4 comments
Closed
2 tasks done
Assignees
Labels
I: dependencies Internal: related to dependencies I: infrastructure Internal: related to Infrastructure (testing, deployment, etc)
Milestone

Comments

@adizere
Copy link
Member

adizere commented Dec 19, 2022

Problem statement

The IBC-go team kindly asked us if we would be able to dedicate some time in assisting them to integrate Hermes into ibctest framework. I think we should help them.

The scope of the work for our team includes as follows:

  • followup on PRs that IBC-go team opens in ibctest, I think @chatton will shoulder most of the work
  • provide synchronous assistance in case Hermes CLIs are unclear
  • provide PR review, suggestions, testing support
  • optional: update Hermes documentation (maybe the features page?) to mention integration in ibctest

This issue is purely for tracking purposes. Likely we won't need to open a PR on the Hermes repo. All work will go in the ibctest repo.

Tasks

References

@adizere adizere added this to the v1.3 milestone Dec 19, 2022
@adizere adizere added I: documentation Internal: improvements or additions to documentation I: dependencies Internal: related to dependencies labels Dec 19, 2022
@seanchen1991 seanchen1991 modified the milestones: v1.3, v1.4 Jan 31, 2023
@seanchen1991
Copy link
Contributor

Marking this issue as closed due to this PR getting merged.

@seanchen1991 seanchen1991 reopened this Mar 20, 2023
@seanchen1991 seanchen1991 added I: infrastructure Internal: related to Infrastructure (testing, deployment, etc) and removed I: documentation Internal: improvements or additions to documentation labels Mar 20, 2023
@chatton
Copy link

chatton commented Mar 20, 2023

The docker images should be able to be built using a workflow similar to this one

@romac
Copy link
Member

romac commented Mar 20, 2023

We already have Docker images on Docker Hub at https://hub.docker.com/r/informalsystems/hermes/tags :)

@chatton
Copy link

chatton commented Mar 21, 2023

Thank you @romac , it looks like these are already built and pushed on tags, this is all we needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies I: infrastructure Internal: related to Infrastructure (testing, deployment, etc)
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants