Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support password authentication in the Solr plugin #5829

Closed
frizner opened this issue May 10, 2019 · 5 comments
Closed

Support password authentication in the Solr plugin #5829

frizner opened this issue May 10, 2019 · 5 comments
Labels
feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@frizner
Copy link
Contributor

frizner commented May 10, 2019

Feature Request

Support password authentication in the Solr plugin, using Basic HTTP Authentication.

Proposal:

The Solr plugin should work with Solr instances with enabled authentication.

Current behavior:

401 status code when the plugin tries to request Solr node with enabled authentication.

Desired behavior:

200 status code

Use case:

Solr nodes, especially in prod environment, often use the authentication.

@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label May 10, 2019
@danielnelson
Copy link
Contributor

Agreed, we should include the regular HTTP options along with this:

  ## Optional HTTP Basic Auth Credentials
  # username = "username"
  # password = "pa$$word"

  ## Optional TLS Config
  # tls_ca = "/etc/telegraf/ca.pem"
  # tls_cert = "/etc/telegraf/cert.pem"
  # tls_key = "/etc/telegraf/key.pem"
  ## Use TLS but skip chain & host verification
  # insecure_skip_verify = false

  ## Amount of time allowed to complete the HTTP request
  # timeout = "5s"

@frizner
Copy link
Contributor Author

frizner commented May 10, 2019

I've changed solr.go in order to have authenticated access and tested it with my Solr instances. May I push a request to some branch?

@danielnelson
Copy link
Contributor

Yes, create a fork of this repo and then push it to a branch on the fork, then you can create the pull request from there.

@frizner
Copy link
Contributor Author

frizner commented May 10, 2019

#5832

@danielnelson
Copy link
Contributor

Closed in #5832

@danielnelson danielnelson added this to the 1.11.0 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

2 participants