Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for results of pid lookup in procstat input #4237

Closed
danielnelson opened this issue Jun 5, 2018 · 1 comment
Closed

Add metric for results of pid lookup in procstat input #4237

danielnelson opened this issue Jun 5, 2018 · 1 comment
Assignees
Labels
area/procstat feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@danielnelson
Copy link
Contributor

Feature Request

Proposal:

There is interest in being able to more easily monitor if a process is running as part of the procstat input (#2687). However, mixing the results of the pid lookup with the metrics about the process itself doesn't mesh well with matching multiple pids.

Current behavior:

If no process is matched Telegraf logs:

E! Error: procstat getting process, exe: [foobar] pidfile: [] pattern: [] user: [] Error running /usr/bin/pgrep: exit status 1

No metrics are emitted.

Desired behavior:

procstat_lookup,pid_finder=pgrep,pattern=foobar pid_count=0i

The log message would be removed.

Use case: [Why is this important (helps with prioritizing requests)]

See #2687

@danielnelson danielnelson added feature request Requests for new plugin and for new features to existing plugins area/procstat labels Jun 5, 2018
@maxunt maxunt self-assigned this Jun 14, 2018
@danielnelson danielnelson added this to the 1.8.0 milestone Jun 21, 2018
@danielnelson
Copy link
Contributor Author

Closed in #4307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/procstat feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

2 participants