[Merged by Bors] - feat: Add Partitioner trait with SiphashRoundRobinPartitioner impl #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link this to issue? |
simlay
reviewed
Apr 16, 2021
sehz
requested changes
Apr 16, 2021
src/client/src/producer.rs
Outdated
| .push(DefaultBatch::new(records)); | ||
| topic_request.name = self.topic.clone(); | ||
| topic_request.partitions.push(partition_request); | ||
| request.acks = 1; |
There was a problem hiding this comment.
this should not be hard coded
There was a problem hiding this comment.
This is how the producer request was already being built (see the removed diff in send_records_raw. If we want to change this we should do it in a new issue
There was a problem hiding this comment.
Got it. Let's create issue to allow developers to configure producer and profile. We probably need producer builder or something like that.
nicholastmosher
force-pushed
the
key-partitioning
branch
from
0c564dc
to
81a2321
Compare
sehz
requested changes
Apr 16, 2021
|
Ok, newest changes:
trait Partitioner {
fn partition(&mut self, keys: &[Option<&[u8]>]) -> Vec<i32>;
fn update_config(&mut self, config: PartitionerConfig);
}
|
sehz
reviewed
Apr 16, 2021
nicholastmosher
force-pushed
the
key-partitioning
branch
from
3233bb7
to
3c4a7c7
Compare
sehz
requested changes
Apr 19, 2021
|
Also, test with replication factor = 2 |
nicholastmosher
force-pushed
the
key-partitioning
branch
from
ee6bebc
to
3b2356e
Compare
|
Can you add this to changelog? |
sehz
requested changes
Apr 20, 2021
sehz
requested changes
Apr 20, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2021
) Closes #838 - Introduces `Partitioner` trait to enable new implementations in the future - Adds `SiphashRoundRobinPartitioner` as a first implementor of `Partitioner` - Uses Siphash-2-4 on records that have keys - Uses round-robin to assign partitions to records with no keys - Adds a `StoreContext<TopicSpec>` to `MetdataStores` for syncing topic metadata - Implements watch requests on SPU for Topic and SPG metadata
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #838
Partitionertrait to enable new implementations in the futureSiphashRoundRobinPartitioneras a first implementor ofPartitionerStoreContext<TopicSpec>toMetdataStoresfor syncing topic metadata