-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple batch produce #896
Simple batch produce #896
Conversation
After a good bit of experimentation, I have not found a way to support all three calling patterns. The one that I have included in this PR is the most general one, and it is still pretty easy to use. @sehz I would like to move forward with merging this as-is, and if we want to prioritize new calling patterns in the future we can make a new issue for it. |
b0e6f39
to
18700bd
Compare
da6d7db
to
a2aee4d
Compare
rebase as well |
4c17568
to
a61c284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Subtask of #847
Here is the first shot at implementing the batch producer. I have included an example and everything is working. The only thing that is still up in the air is trying to see whether we can create a more flexible API.
Currently,
send_all
can take any argument that can turn into an iterator over(Option<Key>, Value)
pairs. This is one example of how calling it looks: