-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use encode_varint to encode vector length in DefaultAsyncBuffer and RecordSets. #752
Use encode_varint to encode vector length in DefaultAsyncBuffer and RecordSets. #752
Conversation
a71529d
to
ca1f709
Compare
rebase |
src/dataplane-protocol/src/record.rs
Outdated
#[test] | ||
fn test_decode_batch_truncation() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted the truncation stuff because it seems that it's a bad use case to take the bytes and modify them directy. Thoughts @sehz?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL. That is to simulate where SPU truncates output bytes in order to comply with max bytes per response. This is critical test to demonstrate receivers can recover much of batches even thought some of the batches are incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of the reason I removed it was because I couldn't figure out how to change the truncation bytes. Given that the SPU truncates it, that'll also have to change (probably why the build is currently failing) so should we keep the encoder changes to RecordSet
or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make it changes only to DefaultAsyncBuffer
7080646
to
c2ede31
Compare
src/dataplane-protocol/src/record.rs
Outdated
#[test] | ||
fn test_decode_batch_truncation() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL. That is to simulate where SPU truncates output bytes in order to comply with max bytes per response. This is critical test to demonstrate receivers can recover much of batches even thought some of the batches are incomplete.
Well then that clears up the importance of it. |
c2ede31
to
8915767
Compare
8915767
to
da4453d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crate version need to be updated as well min platform version
I'm pretty sure I bumped all the right versions. It's kind of a breaking change to all things depending on the |
704f955
to
66d7e4e
Compare
66d7e4e
to
a5906d3
Compare
Closes #706.