fix: better error when watch api versions are not compatible #4149
Conversation
fraidev
changed the title
fraidev
force-pushed
the
watchapi_error
branch
from
8e04898
to
e77d344
Compare
fraidev
changed the title
| @@ -46,6 +46,7 @@ use tracing::instrument; | |||
|
|
|||
| /// The minimum VERSION of the Fluvio Platform that this client is compatible with. | |||
| const MINIMUM_PLATFORM_VERSION: &str = "0.9.0"; | |||
| pub(crate) const VERSION: &str = include_str!("../../../VERSION"); | |||
There was a problem hiding this comment.
did we have this somewhere already? Seems like we should name this PLATFORM_VERSION at least.
Is MINIMUM_PLATFORM_VERSION doing anything useful?
There was a problem hiding this comment.
Yeah, we have this same const in many places:
There was a problem hiding this comment.
Sure, rename only in this case?
There was a problem hiding this comment.
About MINIMUM_PLATFORM_VERSION it's been checked after the lookup_version of the watch API. And will return it:
#[error("Cluster (with platform version {cluster_version}) is older than the minimum required version {client_minimum_version}
To interact with this cluster, please install the matching CLI version using the following command:
curl -fsS https://hub.infinyon.cloud/install/install.sh | VERSION={cluster_version} bash
")]But as we're not updating this const does not seem so useful.
There was a problem hiding this comment.
Should I remove it?
There was a problem hiding this comment.
Hmm, let's just leave it all alone until we get a improved wider compatability check.
Lets leave the constant as VERSION. Forget renaming it PLATFORM_VERSION as it would be out of place with all the other crates.
Related: #3441