feat: add consumer storage to spu #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better also break this into smaller PR |
sehz
requested changes
Mar 22, 2024
crates/fluvio-spu/src/services/internal/fetch_consumer_handler.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-spu/src/services/internal/fetch_consumer_request.rs
Outdated
Show resolved
Hide resolved
|
Should separate out SPUSchema related changes into it's PR so can start merging that |
sehz
reviewed
Mar 26, 2024
| Ok(ReplicaRevStream::new(self.replica.clone())) | ||
| } | ||
|
|
||
| async fn append_batch(&mut self, entries: Vec<Vec<u8>>) -> Result<()> { |
There was a problem hiding this comment.
Can we crate some abstraction for for key value which I assume this is for. Just adding bytes seems to be bit raw
There was a problem hiding this comment.
I think we have enough abstractions here. Not sure I understand your questions.
There was a problem hiding this comment.
Try to add more description which hope to clarify purpose
sehz
reviewed
Mar 26, 2024
sehz
reviewed
Mar 26, 2024
sehz
reviewed
Mar 26, 2024
crates/fluvio-spu/src/services/internal/update_consumer_offset_handler.rs
Show resolved
Hide resolved
sehz
reviewed
Mar 26, 2024
Created #3918 |
|
TTL has been removed |
sehz
reviewed
Mar 28, 2024
|
|
||
| let consumers_replica_id = | ||
| ReplicaKey::new(CONSUMER_STORAGE_TOPIC, <PartitionId as Default>::default()); | ||
|
|
There was a problem hiding this comment.
add more description on what's being done here
sehz
approved these changes
Mar 28, 2024
added 7 commits
March 29, 2024 14:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SPU private API (between SPUs) and public (except fetch list, will be added later) for Offset Mng.