Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(smartmodule): added smartmodule chain support for consumer #2759

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(smartmodule): added smartmodule chain support for consumer #2759

wants to merge 3 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Oct 27, 2022

Added support for multiple smartmodules in StreamFetchRequest and removed all legacy types for SmartModule since we have a chance to break compatibility in the current version.

@galibey galibey requested review from sehz and morenol October 27, 2022 17:07
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks very good. Can you make sure all released crate version is bump up otherwise will not pass bors.
Also, can you test SmartModule works with stable version?

crates/fluvio-protocol-derive/src/ast/prop.rs Show resolved Hide resolved
@sehz sehz added this to the 0.10.1 milestone Oct 31, 2022
@sehz
Copy link
Contributor

sehz commented Oct 31, 2022

Tested with the stable version of Fluvio. Works fine.

@sehz
Copy link
Contributor

sehz commented Oct 31, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 31, 2022
Added support for multiple smartmodules in `StreamFetchRequest` and removed all legacy types for SmartModule since we have a chance to break compatibility in the current version.
@bors
Copy link

bors bot commented Oct 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(smartmodule): added smartmodule chain support for consumer [Merged by Bors] - feat(smartmodule): added smartmodule chain support for consumer Oct 31, 2022
@bors bors bot closed this Oct 31, 2022
@galibey galibey deleted the feat/support-chaining-for-consumers branch October 31, 2022 16:48
davidbeesley pushed a commit to davidbeesley/fluvio that referenced this pull request Oct 31, 2022
…nyon#2759)

Added support for multiple smartmodules in `StreamFetchRequest` and removed all legacy types for SmartModule since we have a chance to break compatibility in the current version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants