[Merged by Bors] - feat(metrics): added metrics to smartengine #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacardin
reviewed
Oct 20, 2022
| .u64_counter("fluvio.smartengine.chain.invocations") | ||
| .init(); | ||
| let records = meter.u64_counter("fluvio.smartengine.chain.records").init(); | ||
| let bytes = meter.u64_counter("fluvio.smartengine.chain.bytes").init(); |
There was a problem hiding this comment.
In the conventions, I think they use io instead of bytes because "bytes" is a unit used in the unit field.
There was a problem hiding this comment.
ok. We will change it later. It won't be used in first version on UI, anyway
nacardin
approved these changes
Oct 20, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 20, 2022
So far, due to current implementation details, we can't send the following metrics: 1. Input records count for chain and smartmodules. 2. Output bytes count for chain and smartmodules. 3. Smartmodule name for all metrics. We will be able to add these metrics later, but it will require changes in the current implementation.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
davidbeesley
pushed a commit
to davidbeesley/fluvio
that referenced
this pull request
Oct 31, 2022
So far, due to current implementation details, we can't send the following metrics: 1. Input records count for chain and smartmodules. 2. Output bytes count for chain and smartmodules. 3. Smartmodule name for all metrics. We will be able to add these metrics later, but it will require changes in the current implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, due to current implementation details, we can't send the following metrics:
We will be able to add these metrics later, but it will require changes in the current implementation.