Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: fluvio cli update check #2679

Closed

Conversation

davidbeesley
Copy link
Contributor

Addresses #2071

@sehz sehz requested a review from tjtelan October 11, 2022 20:10
@davidbeesley davidbeesley changed the title Fluvio cli update check feat: fluvio cli update check Oct 11, 2022
Copy link
Contributor

@tjtelan tjtelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by building fluvio-channel and fluvio-cli with the VERSION file set to an old version first, then installing a plugin

% fluvio install fluvio-cloud  
🔍 Checking for new version

💡 An update to Fluvio is available!
💡     Run 'fluvio update' to install v0.9.33 of Fluvio
Current channel: latest
🎣 Fetching latest version for package: fluvio/fluvio-cloud...
⏳ Downloading package with latest version: fluvio/fluvio-cloud:0.2.2...
🔑 Downloaded and verified package file

Works as expected!

@sehz
Copy link
Contributor

sehz commented Nov 4, 2022

can you rebase this?

@sehz
Copy link
Contributor

sehz commented Nov 5, 2022

bors r+

@sehz sehz added this to the 0.10.1 milestone Nov 5, 2022
@sehz sehz added the CLI label Nov 5, 2022
bors bot pushed a commit that referenced this pull request Nov 5, 2022
Addresses #2071 

Co-authored-by: Dave Beesley <david.beesley@pm.me>
@bors
Copy link

bors bot commented Nov 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: fluvio cli update check [Merged by Bors] - feat: fluvio cli update check Nov 5, 2022
@bors bors bot closed this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants