[Merged by Bors] - feat: Add smdk install support in CLI and release
#2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjtelan
changed the title
smdk install support in CLI and release
sehz
requested changes
Oct 6, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Build failed: |
|
Bors failed because while we had steps to upload SMDK in CI, but we weren't building it in the first place. Hopefully this will fix. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Canceled. |
|
Based on cranelift-codegen's build, I removed the arm and arm7 targets. I hope this build is the one! https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/codegen/build.rs#L174 bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Build failed: |
|
This time it was publish to Github Release ( bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Build failed: |
|
I really wish Bors supported rerunning jobs... bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Build failed: |
Binary name still smdk
Just need to be careful about deriving name from the binary
Make sure we can wildcard the release files
The expected outcome is that CI fails, bc commands prefixed with non-command
Plugins names that don't start with `fluvio-` go into the bin directory
Standardizing on `smartmodule` instead of `smart-module`. Added an alias to the subcommand with a note for future removal
Updated docstrings and tests
Target is unsupported by dependency
I don't see it as a supported target in cranelift-codegen's build system
|
I had to rebase after the last PR, but here we go again bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Build failed: |
|
Removed Windows targets for bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Closes #2644 Adds a name check to `fluvio install`. If it starts with `fluvio-`, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir. The result of `fluvio install smdk --develop` installs the latest published `smdk` to install in my fluvio path. -- Added `smdk` to CI for build and publish for CI Moving a lot of publish and release workflows into Makefile so I can test it easier locally Got rid of the `cargo make` configs since they are out of date and unmaintained
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
smdk install support in CLI and releasesmdk install support in CLI and release
xxchan
added a commit
to xxchan/fluvio
that referenced
this pull request
Feb 19, 2023
which should be deleted in infinyon#2648
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
which should be deleted in #2648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2644
Adds a name check to
fluvio install.If it starts with
fluvio-, it is an extension and gets installed in the channel extension dir. Otherwise, it gets installed in the fluvio bin dir.The result of
fluvio install smdk --developinstalls the latest publishedsmdkto install in my fluvio path.--
Added
smdkto CI for build and publish for CIMoving a lot of publish and release workflows into Makefile so I can test it easier locally
Got rid of the
cargo makeconfigs since they are out of date and unmaintained